Query log doesn't sort by IP 100% correctly... Currently it sorts the same way a filename would sort, like this:
10.0.0.2
10.0.0.3
10.0.0.42
10.0.0.5
10.0.0.68
It should sort like this:
10.0.0.2
10.0.0.3
10.0.0.5
10.0.0.42
10.0.0.68
Ideally, if you know the last octet ends in something like .250, I would sort by IP and scroll to the bottom. With the current sort, it would be almost completely the opposite. .250 would appear very early in the list.
Thank you for your time and consideration,
-Wutnaut
PR which should fix this:
opened 08:25PM - 06 Jun 20 UTC
closed 09:05AM - 10 Aug 20 UTC
**In raising this issue, I confirm the following:** `{please fill the checkboxes… , e.g: [X]}`
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md).
- [x] The issue I am reporting can be *replicated*.
- [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/AdminLTE/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/AdminLTE/issues)).
**How familiar are you with the the source code relevant to this issue?:**
`1`
---
**Expected behaviour:**
Sorting Query Log (and probably Long term database/Query Log) by IP should be numerical.
**Actual behaviour:**
Sorting Query Log (and probably Long term database/Query Log) by IP should is lexicographic.
![Bildschirmfoto zu 2020-06-06 21-30-59](https://user-images.githubusercontent.com/26622301/83953842-2d54dc00-a844-11ea-8d00-9f3e9135cdd4.png)
**Steps to reproduce:**
Suppress RESOLVE_IPV4 in `/etc/pihole/pihole-FTL.conf`, send DNS requests from clients with suitable IP addresses. Sort by IP in Query Log.
Behavior seen on current `devel`
Implemented with the release of Web v5.1.1
Originally published at: https://pi-hole.net/2020/08/09/pi-hole-ftl-v5-2-released/
[image]
Today’s release is mainly to get some much needed changes to FTL out into the wild, including an update of the internal dnsmasq version, however we have a few bug fixes for the core and web components, too.
For core, some improvements have been made to the unsupported OS detection – which should hopefully stop a few common issues we have seen since 5.1 was released.
For those of you using PAD…
committed 10:09AM - 07 Jun 20 UTC
Signed-off-by: Adam Warner <me@adamwarner.co.uk>