Planned internal webserver?

tmaster · August 26, 2022, 7:57pm

I see this Add HTTP server and JSON API by DL6ER · Pull Request #659 · pi-hole/FTL · GitHub

Add HTTP server and JSON API

Not sure if this is a side project or to be merged into the main release.

And wanted to make everyone aware we use lighttpd for other projects at the same time. For me it runs a local webserver virtual radar and dump1090 If your going to add a internal webserver it needs to support being on another port and be compatible with lighttpd running at the same time.. Used to use apache but after installing pi hole lighttpd works much better and uses less memory on the pi. Please dont break everything. And btw it would be nice if pihole didn't keep erasing my lighttpd port configs on reinstalls.

tomporter518 · August 26, 2022, 8:44pm

I use lighttpd for things other than pi-hole as well. To maintain your custom port, you can use an external.conf file in the /etc/lighttpd folder. If your lighttpd version is new enough you can use the syntax:
replace : NAME := VALUE (replace/overwrite earlier value) (since 1.4.46),
like
server.port := 8080 to override the pi-hole supplied value from the lighttpd.conf.

yubiuser · August 26, 2022, 9:38pm

github.com

pi-hole/FTL/blob/98dad054f562d46f482fd5116dcbc6f332451df6/src/config/toml_writer.c#L179


      
          //	Webserver access control list
          //	Allows restrictions to be put on the list of IP addresses which have access to our web server.
          //	The ACL is a comma separated list of IP subnets, where each subnet is pre-pended by either a - or a + sign.
          //	A plus sign means allow, where a minus sign means deny. If a subnet mask is omitted, such as -1.2.3.4, this means
          //	to deny only that single IP address. The default setting is to allow all accesses.
          //	On each request the full list is traversed, and the last (!) match wins.
          //	Example 1: acl = \"-0.0.0.0/0,+127.0.0.1\" ---> deny all accesses, except from 127.0.0.1
          //	Example 2: acl = \"-0.0.0.0/0,+192.168.0.0/16\" ---> deny all accesses, except from the 192.168/16 subnet
          //	IPv6 addresses are specified in form [a:b::c]/64
          	catTOMLstring(fp, 1, "acl", "Webserver access control list.", "<valid ACL>", config.http.acl, defaults.http.acl);
          	catTOMLstring(fp, 1, "port", "Ports to be used by the webserver", "list of <[ip_address:]port>", config.http.port, defaults.http.port);
          
          
          
          	// [http.paths] section
          	catTOMLsection(fp, 1, "http.paths");
          	catTOMLstring(fp, 2, "webroot", "Server root on the host", "<valid path>", config.http.paths.webroot, defaults.http.paths.webroot);
          	catTOMLstring(fp, 2, "webhome", "Sub-directory of the root containing the web interface", "<valid subpath>, both slashes are needed!", config.http.paths.webhome, defaults.http.paths.webhome);

We'll have the port user configurable.

jfb · August 26, 2022, 10:06pm

Please note the prominent warning in the lighttpd configuration file:

###############################################################################
#     FILE AUTOMATICALLY OVERWRITTEN BY PI-HOLE INSTALL/UPDATE PROCEDURE.     #
# ANY CHANGES MADE TO THIS FILE AFTER INSTALL WILL BE LOST ON THE NEXT UPDATE #
#                                                                             #
#              CHANGES SHOULD BE MADE IN A SEPARATE CONFIG FILE:              #
#                         /etc/lighttpd/external.conf                         #
###############################################################################

As another user pointed out, you can make a permanent and non-conflicting port change in file /etc/lighttpd/external.conf.

There is an existing feature request for our installer to be aware of existing lighttpd installs.