Installing 6. over 5. not working

Roberto_Cravallo · November 17, 2023, 8:45am

First: Thank you for this cool tool!!!

I tried this last night and it worked. In Proxmox I cloned my running Pi 5 and did all three upgrade steps as per your documentation. Worked fine, but I missed the part about the 8080!!! So I deleted everything.
Tried again today and it does not work. Something changed overnight. Please see screenshot....

DL6ER · November 17, 2023, 9:01am

Real-time signal 3 in bash could point to a memory shortage. Could you try again?

Looking at the Pi-hole core code, I don't see anything that has been merged over night (the last commit has been 3 days ago).

Roberto_Cravallo · November 17, 2023, 9:44am

I upped the RAM form 4 to 8 GB, no difference. I did the exact same thing (I am pretty sure!!!) yesterday and it worked. Also increased HD from 8-10 GB, same error message.

Roberto_Cravallo · November 19, 2023, 8:39am

I installed a brand new version of Pi5 and then "pihole checkout core development-v6" without a hitch. Frontend still shows. After "pihole checkout web development-v6" I try to load P6 with :8080 and I get a "Directory listing denied".

yubiuser · November 19, 2023, 8:53am

Access the web interface with

192.168.178.99:8080/admin

DL6ER · November 19, 2023, 10:43am

github.com/pi-hole/web

Add HTTP 403 error page

pi-hole:development-v6 ← pi-hole:new/403

opened 10:42AM - 19 Nov 23 UTC

DL6ER

+31 -0

# What does this implement/fix? A very simple PR. ### Before ![Screensh…ot from 2023-11-19 11-40-15](https://github.com/pi-hole/web/assets/16748619/2ed3f3c8-58f2-43ff-90bd-c3008752c2a6) ### Now ![Screenshot from 2023-11-19 11-41-34](https://github.com/pi-hole/web/assets/16748619/e3f3444f-a20b-4ccb-9bb5-4b7c6ffce05b) **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.

Roberto_Cravallo · November 19, 2023, 11:23am

Thank you yubiuser, that fixed it. Not mentioned in the docs, or not so that I could understand it.

TELEPORTER does not import Pi5 teleport. That would be pretty bad it that does not work....

Roberto_Cravallo · November 19, 2023, 3:56pm

Just tried again, still can't upgrade 5. to 6. Since TELEPORT 5 does not work with 6, that would be a real bummer... I don't want to add all those lists by hand again...

DL6ER · November 19, 2023, 5:31pm

Okay, I thought your issue was already solved. Just to make this crystal clear: You have installed a brand-new v5 and were able to upgrade it to v6 just fine. But you also tried upgrading an existing (different!) v5 installation and there you consistently saw the

/etc/.pihole/automated install/basic-install.sh: line 1416: 994 Real-time signal 3

preventing the upgrade from succeeding. Is this correct?

Roberto_Cravallo · November 19, 2023, 5:45pm

Exactly.

I am running this on Proxmox and cloned the working Pi5 container. The upgrade consistency fails as per the screen shot. Fresh Pi6 install worked without a problem!!!

Roberto_Cravallo · November 20, 2023, 4:25pm

If I can be of any help, just ask. I am retired, so time is not a problem!!!

DL6ER · November 20, 2023, 5:47pm

Thanks for the offer, I have been thinking this through but it is actually kinda tough. Even more because we don't get the exact line where this happens, we just know

github.com

pi-hole/pi-hole/blob/2338c9e916ea77ca58e980338c61a31f801a695d/automated install/basic-install.sh#L1416


      
              install -D -m 644 -T -o root -g root ${PI_HOLE_LOCAL_REPO}/advanced/Templates/pihole.cron /etc/cron.d/pihole
              # Randomize gravity update time
              sed -i "s/59 1 /$((1 + RANDOM % 58)) $((3 + RANDOM % 2))/" /etc/cron.d/pihole
              # Randomize update checker time
              sed -i "s/59 17/$((1 + RANDOM % 58)) $((12 + RANDOM % 8))/" /etc/cron.d/pihole
              printf "%b  %b %s\\n" "${OVER}" "${TICK}" "${str}"
          }
          
          # Gravity is a very important script as it aggregates all of the domains into a single HOSTS formatted list,
          # which is what Pi-hole needs to begin blocking ads
          runGravity() {
              # Run gravity in the current shell as user pihole
              { sudo -u pihole bash /opt/pihole/gravity.sh --force; }
          }
          
          # Check if the pihole user exists and create if it does not
          create_pihole_user() {
              local str="Checking for user 'pihole'"
              printf "  %b %s..." "${INFO}" "${str}"
              # If the pihole user exists,
              if id -u pihole &> /dev/null; then

is failing somehow. The last change to the gravity.sh was back in October, so there is also no recent change. You see I'm noting down my thoughts in almost chaotic order here, partially hoping that someone will read through them and say: Dang! I have an idea.

Well, let's just continue thinking here. What we could try is to run pihole -g in the container right after you have seen the error message above. It will be interesting to see if this fails as well, and if, how, or if this works just fine.

I'm also working on v5.0 Teleporter support in v6.0, but this is ongoing work and unlikely to fully work as of yet:

github.com/pi-hole/FTL

Add support for legacy Teleporter archives

pi-hole:development-v6 ← pi-hole:new/teleporter_v5

opened 02:45PM - 20 Nov 23 UTC

DL6ER

+657 -50

# What does this implement/fix? This PR adds importing of Pi-hole pre-v6.0 Te…leporter files. I don't run v5 myself for many years, so I didn't had a very useful Teleporter archive for testing this feature and we may be expecting some rough edges. --- **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.

Roberto_Cravallo · November 20, 2023, 6:29pm

Nope, not working....

Hope this helps!!!

DL6ER · November 20, 2023, 6:49pm

This is indeed helpful - even it not very much - it is a good start!

So the error most likely happens here:

github.com

pi-hole/pi-hole/blob/2338c9e916ea77ca58e980338c61a31f801a695d/gravity.sh#L894-L895


      
          chown pihole:pihole "${gravityTEMPfile}"
          chmod g+w "${piholeDir}" "${gravityTEMPfile}"

indicating we have a problem with

github.com

pi-hole/pi-hole/blob/2338c9e916ea77ca58e980338c61a31f801a695d/gravity.sh#L62


      
          : "${GRAVITY_TMPDIR:=/tmp}"
          
          if [ ! -d "${GRAVITY_TMPDIR}" ] || [ ! -w "${GRAVITY_TMPDIR}" ]; then
            echo -e "  ${COL_LIGHT_RED}Gravity temporary directory does not exist or is not a writeable directory, falling back to /tmp. ${COL_NC}"
            GRAVITY_TMPDIR="/tmp"
          fi
          
          # Set this only after sourcing pihole-FTL.conf as the gravity database path may
          # have changed
          gravityDBfile="${GRAVITYDB}"
          gravityTEMPfile="${GRAVITYDB}_temp"
          gravityDIR="$(dirname -- "${gravityDBfile}")"
          gravityOLDfile="${gravityDIR}/gravity_old.db"
          
          # Generate new SQLite3 file from schema template
          generate_gravity_database() {
            if ! pihole-FTL sqlite3 "${gravityDBfile}" < "${gravityDBschema}"; then
              echo -e "   ${CROSS} Unable to create ${gravityDBfile}"
              return 1
            fi
            chown pihole:pihole "${gravityDBfile}"

and

github.com

pi-hole/pi-hole/blob/2338c9e916ea77ca58e980338c61a31f801a695d/gravity.sh#L43


      
          # Legacy (pre v5.0) list file locations
          whitelistFile="${piholeDir}/whitelist.txt"
          blacklistFile="${piholeDir}/blacklist.txt"
          regexFile="${piholeDir}/regex.list"
          adListFile="${piholeDir}/adlists.list"
          
          localList="${piholeDir}/local.list"
          VPNList="/etc/openvpn/ipp.txt"
          
          piholeGitDir="/etc/.pihole"
          GRAVITYDB=$(getFTLConfigValue files.gravity)
          gravityDBschema="${piholeGitDir}/advanced/Templates/gravity.db.sql"
          gravityDBcopy="${piholeGitDir}/advanced/Templates/gravity_copy.sql"
          
          domainsExtension="domains"
          curl_connect_timeout=10
          
          
          # Set up tmp dir variable in case it's not configured
          : "${GRAVITY_TMPDIR:=/tmp}"

What is the output when you run

pihole-FTL --config files

?

Roberto_Cravallo · November 20, 2023, 7:05pm

The code is like Chinese for me.... But with your guidance I can just run the code you need...

DL6ER · November 20, 2023, 7:12pm

Great! I mean ... "Segmentation fault" is surely not great but we found the root cause. Could you follow the steps under " Prerequirements (only required once)" at gdb - Pi-hole documentation ?

Once done, please run

gdb pihole-FTL --ex "r --config files"

and when it then crashes please enter

where

and provide another screenshot. This may already be what we need fix the bug.

Roberto_Cravallo · November 20, 2023, 7:20pm

Not sure I did it right, this is what I get. Don't understand the "screen" command...

Roberto_Cravallo · November 20, 2023, 7:23pm

Sorry, but I really do not know what I am doing....

rdwebdesign · November 20, 2023, 7:29pm

Type: where

Roberto_Cravallo · November 20, 2023, 7:39pm

This looks better, I guess....