Expected Behaviour:
To be able to assign blacklist entries to a group
-operating system - Docker
-hardware Qnap TS451+
Actual Behaviour:
The blacklist page keeps hiding the Group Assignment column, all it takes is a page refresh and the group assignment column disappears. Cookie clearing resolves the problem until the page is refreshed.Screenshots attached
Debug Token:
https://tricorder.pi-hole.net/9pe82u4mdc
This is the intended behavior. If you want to see the group assignment of black/whitelist you have to go to "Group Management/Domains"
ADD
See this topic for more information
Please follow the below template, it will help us to help you!
Expected Behaviour:
The Group Assignment column should be appearing between the Comment and Action columns on both the Whitelist page and Blacklist page.
Actual Behaviour:
The Group Assignment column appears once and then will never re-appear unless you clear out your browsing history.
Debug Token:
https://tricorder.pi-hole.net/dswp0sj7mg
Further Information:
I can replicate the problem in multiple browsers (Chrome, Edge Chromium,…
Thanks for pointing out. That helps
and I apologise for a duplicate post. Missed it.
DL6ER
May 26, 2020, 9:23pm
4
Thanks for reminding me of this issue.
Bugfix prepared and pushed:
pi-hole:devel
← pi-hole:fix/group_sel_simple_pages
opened 09:23PM - 26 May 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fix initial visibility of group selector on simplified black- and whitelist pages
**How does this PR accomplish the above?:**
Take care of hiding the column even initially (when no state to load from is found in localStorage). As a by-product, this PR fixes some errors with uninitialized localStorage objects.
**What documentation changes (if any) are needed to support this PR?:**
None
1 Like
Glad to be of assistance!
system
Closed
June 16, 2020, 9:36pm
6
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.