Fetching branches fails

Hi,

I'd be glad to help beta test this brand new FTLDNS but can't get the new branch to download.
Of course I have the git client installed on my Raspbian Stretch, everything is up-to-date, here's what I get when running the above commands :

What did I miss ?

(In case this is relevant, I precise my current Pi-Hole is configured with Dnscrypt-Proxy 2.0.7 / DNSSec disabled using this doc and runs flawlessly : DNSCrypt 2.0 · pi-hole/pi-hole Wiki · GitHub)

What happens when you

cd /var/www/html/admin
sudo git fetch --all
cd /etc/.pihole
sudo git fetch --all

The first git command runs OK.
The second one returns the error "fatal: Not a git repository (or any of the parent directories): .git".

It appears I don't have ".git" file in /etc/pihole
But using "locate" command I found a have a ".git" file in /etc/.pihole (with a dot before "pihole", it's a hidden directory).

Sorry, /etc/.pihole is the correct directory.

OK, using the /etc/.pihole directory went OK, but the pihole checkout out commands still fail :

Can your Pi-hole device reach the Internet?

Try sending us a debug token.

pihole -d

or do it through the Web interface:

Yeah my device can reach the Internet, both IPv4 and IPv6 and is currently used as the only DNS resolver for my whole network with no issues.

I've uploaded the log (debug token itj3u4q5h8), oddly my FTL version seems to be "vDev-a1b2fa0" as if the update process worked, but I still have the "master" version of Core and Web.

I can proceed to a complete uninstallation / reinstallation if you think that can help, the only tweaks I made where to use DNScrypt-Proxy 2 and adding a "min-cache-ttl" directive in dnsmasq.conf.

Thanks for you help !

I uninstalled Pihole completely (including package dependancies), then reinstalled it and got a new Pihole install up in no time, chose Google DNS and kept default config for everything else, checked everything was runing smoothly, which was the case.

Then I tried to switch to beta version using the same commands :
echo "FTLDNS" | sudo tee /etc/pihole/ftlbranch
pihole checkout core FTLDNS
pihole checkout web FTLDNS

But again same problem as described in my first screenshot.

And there's no error when typing :

cd /var/www/html/admin
sudo git fetch --all
cd /etc/.pihole
sudo git fetch --all

+1 here the same on Debian Jessie running odroid xu4.

Anyone in this thread, what is the output of

cd /var/www/html/admin
sudo git status
cd /etc/.pihole
sudo git status

root@fr0sh-pi:/var/www/html/admin# sudo git status
Auf Branch master
Ihr Branch ist auf dem selben Stand wie 'origin/master'.
nichts zu committen, Arbeitsverzeichnis unverändert

root@fr0sh-pi:/var/www/html/admin# cd /etc/.pihole
root@fr0sh-pi:/etc/.pihole# sudo git status
Auf Branch master
Ihr Branch ist auf dem selben Stand wie 'origin/master'.
nichts zu committen, Arbeitsverzeichnis unverändert

(it should be something like "on master branch / nothing to commit")

root@DietPi:~# cd /var/www/html/admin
root@DietPi:/var/www/html/admin# sudo git status
Auf Branch master
Ihr Branch ist auf dem selben Stand wie 'origin/master'.
nichts zu committen, Arbeitsverzeichnis unverändert
root@DietPi:/var/www/html/admin# cd /etc/.pihole
root@DietPi:/etc/.pihole# sudo git status
Auf Branch master
Ihr Branch ist auf dem selben Stand wie 'origin/master'.
nichts zu committen, Arbeitsverzeichnis unverändert
root@DietPi:/etc/.pihole#

@jacob.salmela English translation for the above reportings:

On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean

for both, '/var/www/html/admin' and '/etc/.pihole'

1 Like

Yeahhh !!! Finally solved it ! What gave me a hint is that all the people in this thread seem to have a "localized" (non-English) version of Linux.

So just to give it a try I changed my "locales" settings to switch to "en_US.UTF-8", and this time the updated worked fine !

Here are the steps (careful ! this operation will change all settings related to language, date format, etc., but can be rolled back to your language whenever you need to) :

  1. Type "sudo dpkg-reconfigure locales"
  2. Then choose "en_US.UTF-8" and chose it as a default locale on the next screen
  3. Log out and log back in (to apply the modifications on your session)
  4. Proceed with the update commands (echo "FTLDNS"...)

Everything now works fine and the update is applied !

Note that maybe instead of changing the whole default locales, it might be possible to juste enter : export LANG="en_US.UTF-8" then proceed with the update, but I haven't tested this solution.

I guess that the update scripts use the date format or something "localized" and it not working when formatted as FR / DE / etc.

3 Likes

Even if I'm from Germany, my $LANG is set to en_GB.UTF-8, and there were no problems while switching to the FTLDNS branch.

en_GB.UTF-8 is almost identical to en_US UTF8 (same date / number formatting), while FR / DE is very different, so I'm not surprised it works with en_GB.UTF-8.

My comment was just an approval for your finding :slight_smile: Good job :+1:

1 Like

Sadly this doesn't fix it here. I've the same error after changing locales.

@DanSchaper is this related to the LC_ALL=C we've seen fix some issues in the past?

The output of locale on my system is

LANG=en_GB.UTF-8
LANGUAGE=
LC_CTYPE="en_GB.UTF-8"
LC_NUMERIC="en_GB.UTF-8"
LC_TIME="en_GB.UTF-8"
LC_COLLATE="en_GB.UTF-8"
LC_MONETARY="en_GB.UTF-8"
LC_MESSAGES="en_GB.UTF-8"
LC_PAPER="en_GB.UTF-8"
LC_NAME="en_GB.UTF-8"
LC_ADDRESS="en_GB.UTF-8"
LC_TELEPHONE="en_GB.UTF-8"
LC_MEASUREMENT="en_GB.UTF-8"
LC_IDENTIFICATION="en_GB.UTF-8"
LC_ALL=

1 Like