I've been using pihole -q and got some strange output nanopi@nanopi:~$ pihole -q prophet.heise.de /opt/pihole/query.sh: line 37: 21386 Killed awk 'NR==FNR{regexps[$0];next}{for (r in regexps)if($0 ~ r)print r}' <(echo "${lists}") <(echo "${domain}") 2> /dev/null Match found in htt…

Fixed in Malformed wildcard blocking doesn't crash awk. by dschaper · Pull Request #3186 · pi-hole/pi-hole · GitHub

[image] DanSchaper: Opening a bug report on our core or adminlte repositories would be helpful in tracking that specific case. Will do that.

[image] yubiuser: Not sure if it should be like this - it is automatically converted to a regex style. Yes, that is correct. Wildcards are converted to regex value when committed.

Issue opend: https://github.com/pi-hole/pi-hole/issues/3173

This is functionally the same issue as: Pi-hole becomes unresponsive during pihole -d and -q Faulty regex causes -q (and, by extension -d) to stall out (You're not alone!)

Thanks for the hint :slight_smile: As the root cause was the same with us I opened a new topic on that issue: [image] Improve domain list inout fields Beta 5.0 On the black/whitelist page one can add an domain and select the type "wildcard black/whitelist". I …

[image] DanSchaper: It’s not easy to validate regex but I agree that having some kind of check would be helpful. As mentioned in the other thread, this is already in the works for quite some time but will likely not hit v5.0 not not push back the release unnecessarily long. [image] anon55…

Can we call this the solution to the topic then?

Depends on how you (or pihole team) interpret "solution": issue acknowledged and code will be written or code is written and functioning. For me it's solved - I can't contribute any further except of testing the patch when it's ready.

Can I get a teleporter tarball from someone that is seeing this so I can work on it?

I think the glitch may be in something else. Noted on the GitHub issue, but calling awk directly doesn't cause a crash, and I'm seeing that using shell everything seems to be okay. I don't think there actually is a problem with using a * in a wildcard entry as that will always be the first char and …

Pi-hole Userspace

Faulty regex consumes all memory and causes issues with pihole -q

General Beta 5.0

show post in topic

Home
Categories
Guidelines
Terms of Service
Privacy Policy

Powered by Discourse, best viewed with JavaScript enabled