Display of number of blocked entries

It has surely nothing to do with FTLDNS, but after updating the web interface shows "Domains on Blocklist: 491,698".

In contrast the output of 'pihole -g'

[✓] Consolidating blocklists
[✓] Extracting domains from blocklists
[i] Number of domains being pulled in by gravity: 318465
[✓] Removing duplicate domains
[i] Number of unique domains trapped in the Event Horizon: 245852
[i] Number of whitelisted domains: 16
[i] Number of wildcard blocked domains: 109
[✓] Parsing domains into hosts format
[✓] Cleaning up stray matter

It might actually have to do with this. The number on the dashboard is the number from the dnsmasq parser. If you have both IPv4 and IPv6 blocking enabled, then you have two times the number in th hosts lists. In this sense, the display on the dashboard (number of loaded blocking entries) is clearly different from the number gravity shows (number of unique domains).

@mibere What do you think would be a good way of handling this?

P.S.: I'll separate this discussion from the FTLDNS post.

In my opinion it's confusing, as you see :grin: I prefer the previous behavior, I would vote to show the same value as with 'pihole -g'.

1000 blocked domains are 1000 blocked domains, not 2000 just because they're handled in two different "environments" (IPv4, IPv6).

I concur. However, I have to find out how to handle this then (because the resolver just tells me how many lines it has read and one IPv4 and one IPv6 are two lines).

If you can check if IPv4 and IPv6 filtering is enabled, number/2 :smiley:

The value in the web UI is correct now.

Pi-hole v3.3-66-gff47ab1 - AdminLTE v3.3-42-g6e99e1da - FTL vDev-d5b61b8