Audit log / lighttpd errors after pressing button

jpgpi250 · February 18, 2020, 8:53am

pressing the audit button (tools audit log) has no effect, the lighttpd log has the following entries:

2020-02-18 09:47:49: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: comment in /var/www/html/admin/scripts/pi-hole/php/add.php on line 21
2020-02-18 09:47:49: (mod_fastcgi.c.421) FastCGI-stderr: PHP Warning:  SQLite3::prepare(): Unable to prepare statement: 1, table domain_audit has no column named comment in /var/www/html/admin/scripts/pi-hole/php/database.php on line 140

Your debug token is: https://tricorder.pi-hole.net/sqo0xg9jfl

DL6ER · February 18, 2020, 4:43pm

This is already known but I haven't looked at it, so far.

github.com/pi-hole/AdminLTE

Audit log buttons do nothing on 5.0

opened 01:40AM - 22 Jan 20 UTC

closed 09:24AM - 24 Feb 20 UTC

Ghalid

**In raising this issue, I confirm the following:** - [X] I have read and un…derstood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md). - [X] The issue I am reporting can be *replicated*. - [X] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/AdminLTE/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/AdminLTE/issues)). **How familiar are you with the the source code relevant to this issue?:** 1 --- **Expected behaviour:** Clicking the Blacklist, Whitelist, and Audit buttons in the Audit Log page should perform their respective functions **Actual behaviour:** On the beta 5.0, clicking the Audit button does nothing. Clicking the Whitelist ~and Blacklist buttons~ (see comment below) seem to do nothing either except enable the button below to update the white/blacklists (and when updated, the wanted domains don't appear in the respective list). **Steps to reproduce:** 1. Open the Audit Log. 2. Attempt to press any of the buttons. **Debug token provided by [uploading `pihole -d` log](https://discourse.pi-hole.net/t/the-pihole-command-with-examples/738#debug):** I think this can be replicated on any install, but if this is still needed then please ask **Troubleshooting undertaken, and/or other relevant information:** - Installed beta 5.0 on a clean VM, could still reproduce

DL6ER · February 21, 2020, 6:09pm

Okay, solution proposed in

github.com/pi-hole/AdminLTE

Fix audit log page

pi-hole:release/v5.0 ← pi-hole:fix/audit_log

opened 06:08PM - 21 Feb 20 UTC

DL6ER

+62 -54

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Fix #1139 **How does this PR accomplish the above?:** This issue was partially caused by me adding comment fields forgetting to add an exception for tables that do not support those (only the `domain_audit` table). Other parts were due to https://github.com/pi-hole/AdminLTE/pull/1080 where the Javascript code was reformatted without properly checking the consequences. This PR added a space in a place where this changed an offset causing the multiple domains to be added to the blacklist (as you've seen). **What documentation changes (if any) are needed to support this PR?:** None

It would be very nice if you could test our fix with

pihole checkout web fix/audit_log

jpgpi250 · February 21, 2020, 7:35pm

done, no more errors in /var/log/lighttpd/error.log, when pressing the button, but nothing appears to be happening. What is this button suppose to do? sorry for my ignorance.

DL6ER · February 21, 2020, 7:42pm

There are several buttons, which one do you mean in particular?

Audit will simply add the domain to the audit list and tehreby remove from the set of shown domains. The Black- or Whitelist buttons do the same but they also add the domain to the respective list.

jpgpi250 · February 21, 2020, 7:48pm

I mean the audit button (never use the whitelist or blacklist buttons)
So ~~where is the audit list~~ the audited domains are in the domain_audit table (confirmed), how can I modify (remove domains) it (using the web interface), where are the results? Again, sorry for my ignorance, I only test beta5 features, don't say I will use them all in real life...

anon13884536 · February 21, 2020, 8:40pm

When a domain is added to the audit list, it is supposed to disappear from the audit log page on the web interface, and a new domain (that is not yet on the audit list) should appear on the page.

Therefore, you can go over the domains that Pi-hole is querying, and click the "audit" button to mark it as reviewed, in a way, so that the audit log knows that you've looked at that domain already, and thus only show you different domains.

jpgpi250 · February 21, 2020, 8:43pm

I noticed that, so that works.

And is that everything it does?

If that is the case, the solution can be merged, because it works.

DL6ER · February 24, 2020, 9:40am

Yes. It only means "I have seen this domain and acknowledge that is was either permitted or blocked (and I want it to stay like that)". We just memorize them to be able to exclude them from being shown. The stored domains are not used for anything else.

DL6ER · February 25, 2020, 7:20am

The fix has been merged into the beta code. Please go back on track using

pihole checkout web release/v5.0