You have added extra fields to the client database table :
thank you for this , already using it...
However, the web interface doesn't support this yet, there is no option to add the comments.
This makes group management (assign clients to groups) a difficult task, since this interface is still IP based , the comment (friendly name) is NOT visible.
I was also wondering if it would make sense to add clients automatically to the custom DNS list, only if the IP address isn't already in the list?
DL6ER
February 18, 2020, 3:43pm
2
Already there:
pi-hole:release/v5.0
← pi-hole:new/clients_comment_fields
opened 02:56PM - 16 Feb 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Add support for client comment and timestamp fields
**How does this PR accomplish the above?:**
Add fields and processing into `groups.php`.
**What documentation changes (if any) are needed to support this PR?:**
None
Things automatically appearing may cause more confusion than anything else.