Whitelist from WebUI does nothing!

daedal · August 16, 2024, 12:12am

Hello all,

I have done extensive research on this but I have not been able to find any similar situation.
I have also done multiple installs, reconfigures, and checked every possible setting I can find but can't seem to figure out why this is happening. I have also checked permissions on files and directories but doubt that is even the issue.

Expected Behaviour:

I expect to be able to whitelist/blacklist from the WebUI.
I have PiHole running on an RPi.

Actual Behaviour:

Looking at the network traffic in my web browser, no request is being sent to the RPi when I press the buttons. I do not get any notification that the operation happened. I do not see any errors.

Debug Token:

I inspected the Debug Log extensively but since the requests from the WebUI are not making it back to the RPi (they're not occurring in the first place) there's nothing to see there. I am not using any extensions that would block this. I have used multiple machines and multiple browsers to see if the behavior is different, but it's the same.

TL;DR:
The main issue I am encountering is that in my PiHole installation it appears that there is nothing listening to the button press in the WebUI for whitelist/blacklist so nothing happens.

Any help anyone can provide in this case?
Has anyone seen anything like this before?

Thank you

rdwebdesign · August 16, 2024, 1:57am

Please upload a debug log and post just the token URL that is generated after the log is uploaded by running the following command from the Pi-hole host terminal:

pihole -d

daedal · August 16, 2024, 1:23pm

https://tricorder.pi-hole.net/QknXy2ru/

rdwebdesign · August 16, 2024, 5:14pm

Your debug log doesn't show any issues.

This seems to be an issue on the browser.

Do you see any errors in the browser's Console?
(press CTRL+J, or CTRL+SHIFT+I, depending on your browser).
Do you see the same behavior if you access the web interface using a different browser or from a different device?

daedal · August 16, 2024, 5:52pm

Hmm... Thank you for checking the log.

I completely glossed over this, but this is what I see in the browser log:

image911×244 14.8 KB

I do not see this error until after I press the "Whitelist" button in this case.

Yes. I see the same behavior on multiple machines and multiple browsers as well. Today I tested this on multiple browsers and also saw the same issue (same error).

rdwebdesign · August 16, 2024, 6:12pm

I do not see this error until after I press the "Whitelist" button in this case.

Which "Whitelist" button are you pressing exactly?
(Please post a screenshot of the page where you are trying to whitelist the domain, if possible.)

daedal · August 16, 2024, 7:33pm

I see the same error when I press Whitelist from either the Query Log or the Long Term Data screens. This specific one I shared above was from the Long Term Data screen.

rdwebdesign · August 16, 2024, 8:51pm

I can't replicate the issue and we never received similar reports.

Are you able to change other Pi-hole settings via web interface?

daedal · August 16, 2024, 11:02pm

I am able to disable blocking from the WebUI.

Is there anything I can do to diagnose the issue?
Like I mentioned, I tried reinstalling PiHole, but I get the same issue.

Is there anything I can modify that can help point me in the direction of resolving this?

Thank you!

rdwebdesign · August 17, 2024, 12:13am

Are you able to change and save settings in Settings page, like this example?

change_theme

daedal · August 19, 2024, 7:30pm

Hello,

I apologize I haven't looked at this in a couple days.

Yes. I am able to make changes in the settings screen without any issues.

Is there any logical place in your opinion that I can perhaps add a breakpoint to walk through this to try and figure out why it's failing please?

Thank you

rdwebdesign · August 19, 2024, 11:16pm

This shows the error seems to be related only to this button (which is very strange).
As I said before, I can't replicate the issue and we never received similar reports.

Maybe the page is not completely loaded and the modal alert can't be found, causing the error alertModal.modal is not a function. (this is just a guess)

Can you please generate a new debug log? The previous one has expired.

This is the code executed when the button is pressed:

github.com/pi-hole/web

scripts/pi-hole/js/queries.js

be05b0f61


      
          $("#all-queries tbody").on("click", "button", function () {
            var data = tableApi.row($(this).parents("tr")).data();
            if (data[4] === "2" || data[4] === "3" || data[4] === "14" || data[4] === "17") {
              utils.addFromQueryLog(data[2], "black");
            } else {
              utils.addFromQueryLog(data[2], "white");
            }
          });

Which then execute this function:

github.com/pi-hole/web

scripts/pi-hole/js/utils.js

be05b0f61


      
          function addFromQueryLog(domain, list) {
            var token = $("#token").text();
            var alertModal = $("#alertModal");
            var alProcessing = alertModal.find(".alProcessing");
            var alSuccess = alertModal.find(".alSuccess");
            var alFailure = alertModal.find(".alFailure");
            var alNetworkErr = alertModal.find(".alFailure #alNetErr");
            var alCustomErr = alertModal.find(".alFailure #alCustomErr");
            var alList = "#alList";
            var alDomain = "#alDomain";
          
            // Exit the function here if the Modal is already shown (multiple running interlock)
            if (alertModal.css("display") !== "none") {
              return;
            }
          
            var listtype = list === "white" ? "Whitelist" : "Blacklist";
          
            alProcessing.children(alDomain).text(domain);
            alProcessing.children(alList).text(listtype);

This file has been truncated. show original

daedal · August 20, 2024, 12:53pm

I do in fact get to this point correctly...

It appears the problem remains that this function is undefined

Where is this function supposed to be defined please?

daedal · August 20, 2024, 12:56pm

This is what I see for the alertModal currently:

rdwebdesign · August 20, 2024, 11:07pm

This is a Bootstrap 3 function and it is defined in this file: https://raw.githubusercontent.com/pi-hole/web/master/style/vendor/bootstrap/js/bootstrap.min.js

I have no idea why bootstrap is not correctly loaded in your case.

Are you using some browser extension that messes with Bootstrap files or something similar?

Note:

alertModal is the id of the modal dialog used in this page.
.modal() is the bootstrap function.

daedal · August 21, 2024, 7:36pm

Ok, well I am not sure if I should be loading this file or not in Chrome.
I am not using any extensions that would block content at all.

The page sources do not include this file:

I did look for that function, but it's not defined anywhere in the loaded bootstrap file.

On the Pi itself, these are the files listed:

Am I just missing this file?
Is the file supposed to be in there?

daedal · August 21, 2024, 7:53pm

Sorry I was looking in the wrong folder. It is there...

rdwebdesign · August 21, 2024, 8:54pm

Then I don't know why the function is not loaded.

Are you able to see the file contents using the console?

daedal · August 21, 2024, 11:58pm

Well... I'm honestly not sure what I did. Been messing with it for a few hours and changing the files around and trying all kinds of things I've seen online about other people unable to load Bootstrap correctly... and suddenly it works. I also checked my other devices and it seems to work everywhere now!

Thank you so much for your tremendous help getting me to the source of the issue! I really appreciate it!

system · September 11, 2024, 11:58pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.