Whitelist button doesn't work in Query Log page

yubiuser · August 1, 2020, 12:07pm

Is there any issue/error poping up in

/var/log/lighttpd/error.log

when trying to add to black/whitelist from Query Log?

doxx · August 1, 2020, 12:09pm

I get this:

2020-08-01 13:06:32: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507

yubiuser · August 1, 2020, 12:12pm

github.com

pi-hole/AdminLTE/blob/d8d3f316061ba60e0b1dfc6a11f6e917380aca5f/scripts/pi-hole/php/groups.php#L507

    
      
                  $idn_domain = idn_to_ascii($domain, IDNA_NONTRANSITIONAL_TO_ASCII, INTL_IDNA_VARIANT_UTS46);
              }
              if ($idn_domain === false && defined("INTL_IDNA_VARIANT_2003")) {
                  $idn_domain = idn_to_ascii($domain, IDNA_DEFAULT, INTL_IDNA_VARIANT_2003);
              }
              if($idn_domain !== false) {
                  $domain = $idn_domain;
              }
          }
          
          
if(strlen($_POST['type']) === 2 && $_POST['type'][1] === 'W')
          {
              // Apply wildcard-style formatting
              $domain = "(\\.|^)".str_replace(".","\\.",$domain)."$";
          }
          
          
if($type === ListType::whitelist || $type === ListType::blacklist)
          {
              // If adding to the exact lists, we convert the domain lower case and check whether it is valid
              $domain = strtolower($domain);
              if(filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false)

I can replicate the error for both for withelist/blacklist, but for me the domains get added the corresponding black/whitelist.

Linking to github issues that are related

github.com/pi-hole/AdminLTE

Unable to use blacklist button

opened 10:13AM - 28 Jul 20 UTC

phil-ide

**In raising this issue, I confirm the following:** `{please fill the checkboxes…, e.g: [X]}` - [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). - [x] The issue I am reporting can be *replicated*. - [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/pi-hole/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/pi-hole/issues)). **How familiar are you with the the source code relevant to this issue?:** 0 --- **Expected behavior:** After upgrading from v5.0 to v5.1.1: Pressing 'Blacklist' button in the Query Log should add a doman to the blacklist. **Actual behavior:** The popup message informing the domain has been added is displayed as usual. However, checking the blacklist shows it has not been added. From another machine, surfing to the supposedly blacklisted domain shows (in the log) that it has not been blacklisted and has been forwarded. **Steps to reproduce:** Press the blacklist button for a domain in the Query Log, then try to surf to the domain. Checkin the Blacklist for the entry. **Troubleshooting undertaken, and/or other relevant information:** I have performed the "echo 4711 > /var/run/pihole-FTL.port" and "pihole -c" now reports FTL running properly. The issue being reported occurs both before and after these steps.

github.com/pi-hole/AdminLTE

Query Log 'whitelist' button not adding to whitelist

opened 09:48PM - 27 Jul 20 UTC

ray73864

**In raising this issue, I confirm the following:** `{please fill the checkboxes…, e.g: [X]}` - [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). - [X] The issue I am reporting can be *replicated*. - [X] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/pi-hole/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/pi-hole/issues)). **How familiar are you with the the source code relevant to this issue?:** 1 --- **Expected behavior:** When using the web interface in the Query Log screen, I expect that when I click on the 'Whitelist' button, it adds the domain to the whitelist like it is saying it is. **Actual behavior:** After clicking on 'Whitelist', I go to the 'Whitelist' screen and can't see the URL I whitelisted from the 'Query Log' screen on there. **Steps to reproduce:** Go to 'Query Log' screen, click on a 'Whitelist' button, wait for it to finish saying it has added, then go to the 'Whitelist' screen. **Debug token provided by [uploading `pihole -d` log](https://discourse.pi-hole.net/t/the-pihole-command-with-examples/738#debug):** ldacc12lnk **Troubleshooting undertaken, and/or other relevant information:** I manually added the URL to the whitelist

The same error (plus other) popped up when using audit log, but was fixed for the next release already.

github.com/pi-hole/AdminLTE

Audit log buttons adds to whitelist on v5.1.1 and produced lighttpd errors

opened 06:11PM - 22 Jun 20 UTC

closed 06:56AM - 10 Aug 20 UTC

yubiuser

Bug Bugfix in progress

**In raising this issue, I confirm the following:** - [x] I have read and und…erstood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md). - [x] The issue I am reporting can be *replicated*. - [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/AdminLTE/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/AdminLTE/issues)). **How familiar are you with the the source code relevant to this issue?:** 1 --- **Expected behaviour:** Click on "Audit" button on audit log should add the domain to the audit log (`domain_audit` table) **Actual behaviour:** Click on "Audit" button on audit log does not add the domain to the audit log (`domain_audit` table) and produces error in `var/log/lighttpd/error.log` ``` 2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476 2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507 ``` **Steps to reproduce:** ``` nanopi@nanopi:~$ pihole -v Pi-hole version is development v5.0-105-g3aaf9d8 (Latest: v5.0) AdminLTE version is devel v5.0-395-g536ecd69 (Latest: v5.0) FTL version is development vDev-336d72c (Latest: v5.0) ``` Click on "Audit" in the audit log page. **Troubleshooting undertaken, and/or other relevant information:** There was a similar issue before that was fixed before v5.0 was released. Might be a regression. https://github.com/pi-hole/AdminLTE/issues/1139

system · August 22, 2020, 12:21pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.