Whitelist and black list Failure

DL6ER · February 16, 2020, 8:16pm

For those not being able to resolve this, please try

pihole checkout web fix/check_idn

which will disable support for international domains if the required extension is missing.

github.com/pi-hole/AdminLTE

Only use IDN subroutines when the module is available

pi-hole:release/v5.0 ← pi-hole:fix/check_idn

opened 08:18PM - 16 Feb 20 UTC

DL6ER

+11 -4

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Fix a bug seen when incompatible `php-intl` extensions are installed. **How does this PR accomplish the above?:** Only use IDN subroutines when the module is available. We have seen reports that at least DietPi is having issues with not matching PHP base and extension versions. **What documentation changes (if any) are needed to support this PR?:** None

tjamaa · February 16, 2020, 8:22pm

@DanSchaper Yes, this is DietPi on a RPi3 which is only running Pihole for its DNS service. I have noticed this error message too, but I don't know what to make of it. I now checked my other RPi3 running the stable version of Pihole, and it shows the same X-Header error message. Hence it does not seem to be related to Beta5.0, I may have to double-check my lighttpd config.

1xox · February 16, 2020, 8:28pm

@tjamaa: installing php-intl ver. 7.3 fixed the problem apt-get install php7.3-intl
I am running dietpi as well.
@DanSchaper THX for support

tjamaa · February 16, 2020, 8:28pm

Yep, the Whitelist and Blacklist pages are back!

tjamaa · February 16, 2020, 8:47pm

The result of 'apt-get install php7.3-intl':

The following NEW packages will be installed:
  php7.3-intl
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 107 kB of archives.
After this operation, 335 kB of additional disk space will be used.
Get:1 https://packages.sury.org/php stretch/main armhf php7.3-intl armhf 7.3.14-5+0~20200202.52+debian9~1.gbpa71879 [107 kB]
Fetched 107 kB in 0s (113 kB/s)
Selecting previously unselected package php7.3-intl.
(Reading database ... 22515 files and directories currently installed.)
Preparing to unpack .../php7.3-intl_7.3.14-5+0~20200202.52+debian9~1.gbpa71879_armhf.deb ...
Unpacking php7.3-intl (7.3.14-5+0~20200202.52+debian9~1.gbpa71879) ...
Processing triggers for php7.3-fpm (7.3.14-5+0~20200202.52+debian9~1.gbpa71879) ...
Setting up php7.3-intl (7.3.14-5+0~20200202.52+debian9~1.gbpa71879) ...

Creating config file /etc/php/7.3/mods-available/intl.ini with new version
Processing triggers for php7.3-fpm (7.3.14-5+0~20200202.52+debian9~1.gbpa71879) ...
Processing triggers for php7.3-cli (7.3.14-5+0~20200202.52+debian9~1.gbpa71879) ...

I then went back to checkout core and ftl release/5.0, and the Whitelist and Blacklist pages appeared. Problem solved it seems.