Sorry... my mistake
I saw one command above for a debug log and thought you were running a container.
I don't know what is causing this issue.
This kinda reminds me of an issue with V5 where the incorrect versions were being displayed. I wonder if its worth deleting /etc/pihole/versions and let it rebuild.
Not a bad idea.
Worth a shot.
For giggles I deleted my versions file and replace it with the "bad" versions file and I could recreate @tesla3 issue. Running sudo pihole updatechecker afterwards put it back correctly and the website was fine again.
Interesting. I recreated mine as well again and it just keeps coming back with null for the github versions. I have no idea why it's doing that. It's a fresh install of Ubuntu server 24.04.2 with all the latest updates. Nothing custom is on here at all. Is there a cmd for getting the github versions that I can manually run to see the output?
Can you run sudo bash -x /opt/pihole/updatecheck.sh and paste the output?
root@pihole:/etc/pihole# bash -x /opt/pihole/updatecheck.sh
+ . /opt/pihole/utils.sh
+ rm -f /etc/pihole/GitHubVersions
+ rm -f /etc/pihole/localbranches
+ rm -f /etc/pihole/localversions
+ VERSION_FILE=/etc/pihole/versions
+ touch /etc/pihole/versions
+ chmod 644 /etc/pihole/versions
++ cat /pihole.docker.tag
+ DOCKER_TAG=
+ release_regex='^([0-9]+\.){1,2}(\*|[0-9]+)(-.*)?$'
+ regex='^([0-9]+\.){1,2}(\*|[0-9]+)(-.*)?$|(^nightly$)|(^dev.*$)'
+ [[ ! '' =~ ^([0-9]+\.){1,2}(\*|[0-9]+)(-.*)?$|(^nightly$)|(^dev.*$) ]]
+ unset DOCKER_TAG
+ [[ '' == \r\e\b\o\o\t ]]
++ get_local_version /etc/.pihole
++ cd /etc/.pihole
++ git describe --tags --always
+ CORE_VERSION=v6.0.4
+ addOrEditKeyValPair /etc/pihole/versions CORE_VERSION v6.0.4
+ local file=/etc/pihole/versions
+ local key=CORE_VERSION
+ local value=v6.0.4
+ touch /etc/pihole/versions
+ grep -q '^CORE_VERSION=' /etc/pihole/versions
+ sed -i '/^CORE_VERSION=/c\CORE_VERSION=v6.0.4' /etc/pihole/versions
++ get_local_branch /etc/.pihole
++ cd /etc/.pihole
++ git rev-parse --abbrev-ref HEAD
+ CORE_BRANCH=master
+ addOrEditKeyValPair /etc/pihole/versions CORE_BRANCH master
+ local file=/etc/pihole/versions
+ local key=CORE_BRANCH
+ local value=master
+ touch /etc/pihole/versions
+ grep -q '^CORE_BRANCH=' /etc/pihole/versions
+ sed -i '/^CORE_BRANCH=/c\CORE_BRANCH=master' /etc/pihole/versions
++ get_local_hash /etc/.pihole
++ cd /etc/.pihole
++ git rev-parse --short=8 HEAD
+ CORE_HASH=567bb724
+ addOrEditKeyValPair /etc/pihole/versions CORE_HASH 567bb724
+ local file=/etc/pihole/versions
+ local key=CORE_HASH
+ local value=567bb724
+ touch /etc/pihole/versions
+ grep -q '^CORE_HASH=' /etc/pihole/versions
+ sed -i '/^CORE_HASH=/c\CORE_HASH=567bb724' /etc/pihole/versions
++ get_remote_version pi-hole master
++ [[ master == \m\a\s\t\e\r ]]
++ curl -s https://api.github.com/repos/pi-hole/pi-hole/releases/latest
++ jq --raw-output .tag_name
+ GITHUB_CORE_VERSION=null
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_CORE_VERSION null
+ local file=/etc/pihole/versions
+ local key=GITHUB_CORE_VERSION
+ local value=null
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_CORE_VERSION=' /etc/pihole/versions
+ sed -i '/^GITHUB_CORE_VERSION=/c\GITHUB_CORE_VERSION=null' /etc/pihole/versions
++ get_remote_hash pi-hole master
++ git ls-remote https://github.com/pi-hole/pi-hole --tags master
++ awk '{print substr($0, 1,8);}'
+ GITHUB_CORE_HASH=567bb724
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_CORE_HASH 567bb724
+ local file=/etc/pihole/versions
+ local key=GITHUB_CORE_HASH
+ local value=567bb724
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_CORE_HASH=' /etc/pihole/versions
+ sed -i '/^GITHUB_CORE_HASH=/c\GITHUB_CORE_HASH=567bb724' /etc/pihole/versions
++ get_local_version /var/www/html/admin
++ cd /var/www/html/admin
++ git describe --tags --always
+ WEB_VERSION=v6.0.1
+ addOrEditKeyValPair /etc/pihole/versions WEB_VERSION v6.0.1
+ local file=/etc/pihole/versions
+ local key=WEB_VERSION
+ local value=v6.0.1
+ touch /etc/pihole/versions
+ grep -q '^WEB_VERSION=' /etc/pihole/versions
+ sed -i '/^WEB_VERSION=/c\WEB_VERSION=v6.0.1' /etc/pihole/versions
++ get_local_branch /var/www/html/admin
++ cd /var/www/html/admin
++ git rev-parse --abbrev-ref HEAD
+ WEB_BRANCH=master
+ addOrEditKeyValPair /etc/pihole/versions WEB_BRANCH master
+ local file=/etc/pihole/versions
+ local key=WEB_BRANCH
+ local value=master
+ touch /etc/pihole/versions
+ grep -q '^WEB_BRANCH=' /etc/pihole/versions
+ sed -i '/^WEB_BRANCH=/c\WEB_BRANCH=master' /etc/pihole/versions
++ get_local_hash /var/www/html/admin
++ cd /var/www/html/admin
++ git rev-parse --short=8 HEAD
+ WEB_HASH=42e7279a
+ addOrEditKeyValPair /etc/pihole/versions WEB_HASH 42e7279a
+ local file=/etc/pihole/versions
+ local key=WEB_HASH
+ local value=42e7279a
+ touch /etc/pihole/versions
+ grep -q '^WEB_HASH=' /etc/pihole/versions
+ sed -i '/^WEB_HASH=/c\WEB_HASH=42e7279a' /etc/pihole/versions
++ get_remote_version web master
++ [[ master == \m\a\s\t\e\r ]]
++ jq --raw-output .tag_name
++ curl -s https:// api.github.com/repos/pi-hole/web/releases/latest **<----I had to edit so it would allow me to post it**
+ GITHUB_WEB_VERSION=null
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_WEB_VERSION null
+ local file=/etc/pihole/versions
+ local key=GITHUB_WEB_VERSION
+ local value=null
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_WEB_VERSION=' /etc/pihole/versions
+ sed -i '/^GITHUB_WEB_VERSION=/c\GITHUB_WEB_VERSION=null' /etc/pihole/versions
++ get_remote_hash web master
++ awk '{print substr($0, 1,8);}'
++ git ls-remote https://github.com/pi-hole/web --tags master
+ GITHUB_WEB_HASH=42e7279a
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_WEB_HASH 42e7279a
+ local file=/etc/pihole/versions
+ local key=GITHUB_WEB_HASH
+ local value=42e7279a
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_WEB_HASH=' /etc/pihole/versions
+ sed -i '/^GITHUB_WEB_HASH=/c\GITHUB_WEB_HASH=42e7279a' /etc/pihole/versions
++ pihole-FTL version
+ FTL_VERSION=v6.0.2
+ addOrEditKeyValPair /etc/pihole/versions FTL_VERSION v6.0.2
+ local file=/etc/pihole/versions
+ local key=FTL_VERSION
+ local value=v6.0.2
+ touch /etc/pihole/versions
+ grep -q '^FTL_VERSION=' /etc/pihole/versions
+ sed -i '/^FTL_VERSION=/c\FTL_VERSION=v6.0.2' /etc/pihole/versions
++ pihole-FTL branch
+ FTL_BRANCH=master
+ addOrEditKeyValPair /etc/pihole/versions FTL_BRANCH master
+ local file=/etc/pihole/versions
+ local key=FTL_BRANCH
+ local value=master
+ touch /etc/pihole/versions
+ grep -q '^FTL_BRANCH=' /etc/pihole/versions
+ sed -i '/^FTL_BRANCH=/c\FTL_BRANCH=master' /etc/pihole/versions
++ pihole-FTL --hash
+ FTL_HASH=ac500d5f
+ addOrEditKeyValPair /etc/pihole/versions FTL_HASH ac500d5f
+ local file=/etc/pihole/versions
+ local key=FTL_HASH
+ local value=ac500d5f
+ touch /etc/pihole/versions
+ grep -q '^FTL_HASH=' /etc/pihole/versions
+ sed -i '/^FTL_HASH=/c\FTL_HASH=ac500d5f' /etc/pihole/versions
++ get_remote_version FTL master
++ [[ master == \m\a\s\t\e\r ]]
++ curl -s https://api.github.com/repos/pi-hole/FTL/releases/latest
++ jq --raw-output .tag_name
+ GITHUB_FTL_VERSION=null
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_FTL_VERSION null
+ local file=/etc/pihole/versions
+ local key=GITHUB_FTL_VERSION
+ local value=null
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_FTL_VERSION=' /etc/pihole/versions
+ sed -i '/^GITHUB_FTL_VERSION=/c\GITHUB_FTL_VERSION=null' /etc/pihole/versions
++ get_remote_hash FTL master
++ git ls-remote https://github.com/pi-hole/FTL --tags master
++ awk '{print substr($0, 1,8);}'
+ GITHUB_FTL_HASH=ac500d5f
+ addOrEditKeyValPair /etc/pihole/versions GITHUB_FTL_HASH ac500d5f
+ local file=/etc/pihole/versions
+ local key=GITHUB_FTL_HASH
+ local value=ac500d5f
+ touch /etc/pihole/versions
+ grep -q '^GITHUB_FTL_HASH=' /etc/pihole/versions
+ sed -i '/^GITHUB_FTL_HASH=/c\GITHUB_FTL_HASH=ac500d5f' /etc/pihole/versions
+ [[ -n '' ]]
root@pihole:/etc/pihole#
Interesting....
What is the output of curl -s https://api.github.com/repos/pi-hole/pi-hole/releases/latest ?
LOL I already was running that.
The blank is my IP. So it looks like it's something hitting up github too much. I don't think I have anything on my network that is doing that besides these nodes. I assume that the checks don't occur randomly? Do they happen only when manually checking for updates or does it happen every time I load the web interface?
I think there is a cron job to run it every... 12 (?? Not sure, going from memory) hours. But it shouldn't be running frequently enough to trigger rate limits!
It shouldn't be checking on every visit to the web interface... We learned not to do that a long time ago.
1 Like
I have 2 separate instances of pihole running. One for my guest network and one for internal. But even still, I wouldn't think that it's checking 60 times an hour, as that's what github says they are rate limiting at. Really odd. I may need to jump into my FW and start looking at traffic. If you're thinking that this is the issue, then I'm sure we can close this out and I will investigate my network.
I think we'd have had wider reports by now if it was a serious issue... but that's not to say there isn't a bug... it could just be that you're coming up against an edge case.
edit: OR there is some other process on your network that is hammering the Github API and causing your IP to be ratelimited.
I have a suspicion about my son's Ubuntu box. I'll shut it down and see if that resolves it. Might be a good case for a KB article about how to check this out if you're getting null values in there. It makes a lot of sense that being rate limited would give you nulls in those values.
Yup, that fixed it. It was a rate limiting issue on my home network. Thank you all for the help! I appreciate the assistance in tracking this down.
1 Like
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.