Update Gravity website broken - Reproducable and possible Solution found

jf62 · March 21, 2024, 10:02pm

If I try to do a manual update of gravity db then the website show for a second the update button and then go to System settings

jf62 · March 22, 2024, 3:03pm

Are I'm the only one with this error which came up after last update of Web Interface to Version vDev (development-v6, 7d51f402) ?

seh2000 · March 22, 2024, 4:59pm

Having the same version on two Raspberry Pi's, manual update works fine here.

Core vDev (development-v6, 206cf9c4) FTL vDev (development-v6, 0d2fcd09)Web interface vDev (development-v6, 7d51f402)

rdwebdesign · March 22, 2024, 5:10pm

No one else reported similar problems.
This seems to be an issue in your system.

We need more information.

Please upload a debug log and post just the token URL that is generated after the log is uploaded by running the following command from the Pi-hole host terminal:

pihole -d

jf62 · March 22, 2024, 5:13pm

https://tricorder.pi-hole.net/yghzHV5P/

jf62 · March 22, 2024, 8:35pm

Since I have a Proxmox system with backups, I went back to the version

Core vDev (development-v6, 206cf9c4)
FTL vDev (development-v6, c835795a)
Web interface vDev (development-v6, 71d396e3)

and the Bug isn't there

jf62 · March 23, 2024, 1:57pm

I tested further and can reproduce the bug.
If Settings are set to BASIC the error occures, If I change to EXPERT all work as expected

rdwebdesign · March 23, 2024, 6:06pm

OK. I can reproduce the issue.

We need to investigate, but apparently this is a side effect of a change made when we introduced the new Settings Level toggle selector.

DL6ER · March 23, 2024, 6:50pm

Thanks for the report, the proposed bug fix is here awaiting review:

github.com/pi-hole/web

Fix incorrect redirection

pi-hole:development-v6 ← pi-hole:fix/redirect_settings

opened 06:49PM - 23 Mar 24 UTC

DL6ER

+6 -1

# What does this implement/fix? We should not try to apply settings levels (i…ncl. all the consequences such as ill-fated redirects) when we have already detected that there are no expert-settings elements on this page. --- **Related issue or feature (if applicable):** https://github.com/pi-hole/web/issues/2992 **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.