In the previous release one was able to drill down on an IP address in the Network Overview section. In the beta the drill down seems to be not working. Is this by design or a bug?
DL6ER
January 20, 2020, 4:32pm
2
This is a bug. I'll check it out once I'm through with all the posts that came in today.
DL6ER
January 20, 2020, 5:57pm
3
Indeed, IP address sorting is broken as we support multiple IPs per device in the same row now.
The question that arises not: How to sort by multiple IPs in the same row?
We could sort by the first IP for each device, but is this intended behavior?
Input from others would be appreciated, @jfb @PromoFaux @DanSchaper .
DL6ER
January 20, 2020, 6:04pm
4
Possible fix for the sorting issue
pi-hole:release/v5.0 ← pi-hole:fix/network_table_ip_sorting
opened 06:04PM - 20 Jan 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fix bug described on Discourse: https://discourse.pi-hole.net/t/unable-to-drill-down-in-network-overview/27175
Note that this is only one possible solution and needs to be discussed.
**How does this PR accomplish the above?:**
Sort by first IP if multiple IPs are available for a given device
**What documentation changes (if any) are needed to support this PR?:**
None
jfb
January 20, 2020, 6:07pm
6
If sorting is offered for IP, then it should be the first IP listed for that Hardware address.
DL6ER
January 20, 2020, 6:37pm
12
This re-installs clickable links for all shown IP addresses:
pi-hole:release/v5.0 ← pi-hole:new/network_table_IP_links
opened 06:37PM - 20 Jan 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Address a complaint raised on Discourse: https://discourse.pi-hole.net/t/unable-to-drill-down-in-network-overview/27175
**How does this PR accomplish the above?:**
Automatically prepare and add links to the Query Log page
**What documentation changes (if any) are needed to support this PR?:**
None
DL6ER
February 3, 2020, 10:07pm
13
@cipherwar This has now been reviewed and merged into the beta release.