mibere
October 7, 2017, 5:15pm
1
On the admin page there are currently three graphs at the bottom: 'Top Domains', 'Top Blocked Domains' and 'Top Clients'.
There is a free space on the bottom right, a free space for a fourth graph - something like 'Top Blocked Domains per Client'.
I would like to have a graph (design and descending sorting like the existing ones, columns 'Client' / 'Hits' (?) / 'Frequency') where I can see a list of devices/clients with the highest number of blocked domains. This graph should answer me 'are there more blocked domains on my device A than device B' or 'which device has the highest number of blocked domains'.
2 Likes
I'd like to second this - I think it could be useful to more rapidly identify problem clients or problem users.
Mcat12
February 5, 2018, 9:26pm
3
There's an issue with the Discourse plugins atm, but once they come back up you can upvote this request to show your support.
DL6ER
May 10, 2018, 11:24am
4
Coming back to this:
Such a feature would not be hard to implement.
Would you like to see this as an additional table (i.e. one “Top Clients” and one “Top clients (blocked)”) or rather remove the existing table and replace it with two new ones (one “Top Clients (blocked)” one “Top Clients (permitted)”) or something else?
mibere
May 10, 2018, 12:27pm
5
Yes. The existing and unchanged 'Top Clients' & a new one 'Top clients (blocked)'.
1 Like
DL6ER
May 10, 2018, 1:17pm
6
See
pi-hole:devel
← pi-hole:new/top_clients_blocked
opened 01:16PM - 10 May 18 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have re… ad and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
- [X] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#git-commit---signoff))
---
**What does this PR aim to accomplish?:**
Add a fourth table listing the number of blocked queries per client:
![screenshot-2018-5-10 pi-hole admin console](https://user-images.githubusercontent.com/16748619/39871391-efee5f38-5464-11e8-9339-7cae304e009a.png)
Note that this is a feature request from [Discourse](https://discourse.pi-hole.net/t/top-blocked-domains-per-client/5055).
**How does this PR accomplish the above?:**
- Add new API endpoint `api.php?topClientsBlocked`
- Add new table to dashboard
- Extend existing "Top Clients" table JS code to also treat the new table (we get both datasets in one query). This is duplicating the functionality we already have for the other two tables (Top Domains/Top Ads) which basically follow the same logic.
**What documentation changes (if any) are needed to support this PR?:**
None
pi-hole:development
← pi-hole:new/more_per_client_details
opened 12:43PM - 10 May 18 UTC
**By submitting this pull request, I confirm the following (please check boxes, … eg [X]) _Failure to fill the template will close your PR_:**
***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***
- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).
- [X] I have checked that [another pull request](https://github.com/pi-hole/FTL/pulls) for this purpose does not exist.
- [X] I have considered, and confirmed that this submission will be valuable to others.
- [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- [X] I give this submission freely, and claim no ownership to its content.
**How familiar are you with the codebase?:**
## 10
---
This adds a new counter for blocked queries *per client*. This duplicates the functionality we already have for domains (either total or blocked count).
The new info can be queried from the API by specifying the keyword `blocked` in addition to `>top-clients`. This option is in agreement with other available options, e.g. `>top-clients withzero blocked (29)` will work as expected.
_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._
for implementation details
1 Like
DL6ER
May 11, 2018, 2:43pm
7
This feature has been implemented and will be released with Pi-hole v4.0.
I'm closing this feature request now to release your spent votes.
1 Like