Temperaturelimit undefined since latest update

Tntdruid · January 6, 2022, 3:50pm

Getting this on my Pi-Hole on my VM server.

There was a problem applying your settings.
Debugging information:
PHP error (2): Undefined variable $temperaturelimit in /var/www/html/admin/scripts/pi-hole/php/header.php:379

yubiuser · January 6, 2022, 4:04pm

Thanks for the report. This is a bug. Reason is we only set temperaturelimit if output is numeric. But this is only the case when we found a temp sensor. But this might not be the case in a VM

github.com

pi-hole/AdminLTE/blob/cb7a866ff66cbd67252fb8cad8601870e7fe0d4b/scripts/pi-hole/php/header.php#L28-L69

    
      
          if(file_exists("/sys/class/thermal/thermal_zone0/temp"))
          {
              $output = rtrim(file_get_contents("/sys/class/thermal/thermal_zone0/temp"));
          }
          elseif (file_exists("/sys/class/hwmon/hwmon0/temp1_input"))
          {
              $output = rtrim(file_get_contents("/sys/class/hwmon/hwmon0/temp1_input"));
          }
          else
          {
              $output = "";
          }
          
          
// Test if we succeeded in getting the temperature
          if(is_numeric($output))
          {
              // $output could be either 4-5 digits or 2-3, and we only divide by 1000 if it's 4-5
              // ex. 39007 vs 39
              $celsius = intval($output);

This file has been truncated. show original

github.com

pi-hole/AdminLTE/blob/cb7a866ff66cbd67252fb8cad8601870e7fe0d4b/scripts/pi-hole/php/header.php#L378-L381

    
      
          $tempcolor = "text-vivid-blue";
          if ($celsius > $temperaturelimit) {
              $tempcolor = "text-red";
          }

We'll fix this

yubiuser · January 6, 2022, 4:06pm

Do you get any Temp information in the status panel or No temp sensor found?

Tntdruid · January 6, 2022, 4:18pm

Yes i do.

yubiuser · January 6, 2022, 4:19pm

Thanks.

Hope to get a fix out for this tonight.

yubiuser · January 6, 2022, 7:25pm

github.com/pi-hole/AdminLTE

Rework the temp info in the status panel

pi-hole:devel ← pi-hole:fix/temp

opened 07:25PM - 06 Jan 22 UTC

yubiuser

+13 -13

- [x] I have read and understood the [contributors guide](https://github.com/pi-…hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template. - [x] I have made only one major change in my proposed changes. - [x] I have commented my proposed changes within the code. - [ ] I have tested my proposed changes. - [x] I am willing to help maintain this change if there are issues with it later. - [x] I give this submission freely and claim no ownership. - [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) - [x] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff)) --- **What does this PR aim to accomplish?:** 1. Set `temperaturlimit` explicitly even if no temp sensor has been found. Fixes a warning reported here: https://discourse.pi-hole.net/t/temperaturelimit-undefined-since-latest-update/52302 2. Only show temp info at all if temp info is available. There is not much use in seeing `No temp sensor found`

system · January 27, 2022, 7:26pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.