Stop wiping dnsmasq.conf with every update

dirtNnasty · 2019-02-09 11:09:02 UTC

I customized my dnsmasq.conf but since pihole 4 every little update wipes my config.

Please stop doing that. Thanks.

DanSchaper · 2019-02-09 14:18:05 UTC

Set your customizations in /etc/dnsmasq.d/60-mysettings.conf instead and they won’t be overwritten.

dirtNnasty · 2019-02-10 10:40:05 UTC

I will check that with the next update.

msatter · 2019-02-10 11:13:57 UTC

Maybe better to do it now and don’t forget to comment out or erase the extra lines in dnsmasq.conf after you moved them the 60-mysettings.conf.

jfb · 2019-02-10 12:58:56 UTC

Here is the code where you can see why it won’t be overwritten:

github.com

pi-hole/pi-hole/blob/master/automated install/basic-install.sh#L1247


    fi
else
    # If a file cannot be found,
    printf "  %b No dnsmasq.conf found... restoring default dnsmasq.conf..." "${INFO}"
    # restore the default one
    cp ${dnsmasq_original_config} ${dnsmasq_conf}
    printf "%b  %b No dnsmasq.conf found... restoring default dnsmasq.conf...\\n" "${OVER}"  "${TICK}"
fi


printf "  %b Copying 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf..." "${INFO}"
# Check to see if dnsmasq directory exists (it may not due to being a fresh install and dnsmasq no longer being a dependency)
if [[ ! -d "/etc/dnsmasq.d"  ]];then
    mkdir "/etc/dnsmasq.d"
fi
# Copy the new Pi-hole DNS config file into the dnsmasq.d directory
cp ${dnsmasq_pihole_01_snippet} ${dnsmasq_pihole_01_location}
printf "%b  %b Copying 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf\\n" "${OVER}"  "${TICK}"
# Replace our placeholder values with the GLOBAL DNS variables that we populated earlier
# First, swap in the interface to listen on
sed -i "s/@INT@/$PIHOLE_INTERFACE/" ${dnsmasq_pihole_01_location}
if [[ "${PIHOLE_DNS_1}" != "" ]]; then

dirtNnasty · 2019-02-10 14:41:11 UTC

ok, understood.