Stop wiping dnsmasq.conf with every update

dirtNnasty · February 9, 2019, 11:09am

I customized my dnsmasq.conf but since pihole 4 every little update wipes my config.

Please stop doing that. Thanks.

DanSchaper · February 9, 2019, 2:18pm

Set your customizations in /etc/dnsmasq.d/60-mysettings.conf instead and they won't be overwritten.

dirtNnasty · February 10, 2019, 10:40am

I will check that with the next update.

jfb · February 10, 2019, 12:58pm

Here is the code where you can see why it won't be overwritten:

github.com

pi-hole/pi-hole/blob/master/automated install/basic-install.sh#L1247


      
              printf "  %b Existing dnsmasq.conf found..." "${INFO}"
              # If a specific string is found within this file, we presume it's from older versions on Pi-hole,
              if grep -q "${dnsmasq_pihole_id_string}" "${dnsmasq_conf}" ||
                 grep -q "${dnsmasq_pihole_id_string2}" "${dnsmasq_conf}"; then
                  printf " it is from a previous Pi-hole install.\\n"
                  printf "  %b Backing up dnsmasq.conf to dnsmasq.conf.orig..." "${INFO}"
                  # so backup the original file,
                  mv -f "${dnsmasq_conf}" "${dnsmasq_conf_orig}"
                  printf "%b  %b Backing up dnsmasq.conf to dnsmasq.conf.orig...\\n" "${OVER}"  "${TICK}"
                  printf "  %b Restoring default dnsmasq.conf..." "${INFO}"
                  # and replace it with the default
                  install -D -m 644 -T "${dnsmasq_original_config}" "${dnsmasq_conf}"
                  printf "%b  %b Restoring default dnsmasq.conf...\\n" "${OVER}"  "${TICK}"
              else
                  # Otherwise, don't to anything
                  printf " it is not a Pi-hole file, leaving alone!\\n"
              fi
          else
              # If a file cannot be found,
              printf "  %b No dnsmasq.conf found... restoring default dnsmasq.conf..." "${INFO}"
              # restore the default one

dirtNnasty · February 10, 2019, 2:41pm

ok, understood.