That would be my pleasure!
But that would required more extensive testing and probably some code review. The code was written for modern browsers mainly, so on older devices could be some visual imperfections or bugs.
(There are some more things I have in mind that wanted to do/try, but I had to draw a line somewhere and relase something )
It looks very smart! Is it possible to keep the Pi-hole LCARS theme (Settings > Web interface > Theme and Layout > Star Trek LCARS theme (dark)) and have both your themes available too? Or does one have to choose one of your two themes, and then that replaces the Pi-hole original LCARS theme? Apologies if I've misunderstood what "[i] This theme replaces the original blue LCARS theme" is saying.
The "installation" described in the README is to replace the lcars.css file in your pi-hole. You could rename the file and replace another one of the available themes there, but you cannot add a new one.
I was always struck by how often an issue somewhere on the ship would cause the "console to overload" and explode, sending the poor operator halfway across the bridge. Using this theme, I hope that we're safe in the event of any DNS errors! Maybe a hardcore = enabled option.
Hahahaha, I was watching DS9 last night, the episode where the Defiant takes on the Klingon armada and that's exactly what happens. Defiant takes a phaser blast and it's the fire control panel that blows up. Seems like some bad engineering there.
To which branch I should make the PR? devel or development-v6?
I presume that in v6 there are much more changes and there is high probability that something will be broken ...
Question about development
Let's say I want to prepare the theme for the v6. How I can run the DEV version? I searched throught the documentation, but there is no mention of dev enviroment, only contributions.
I found some answers with the help of ChatGPT and it looks ok, just want to be sure that I'm on the right track. Thanks.
Dev version installation
git clone --depth 1 --branch development https://github.com/pi-hole/pi-hole.git Pi-hole
cd Pi-hole/automated install/
sudo bash basic-install.sh
As this seems (almost?) ready to be shipped we discussed internally that your theme could be included still into v5. v6 will certainly break some things and there is no release ETA yet - there is no need to wait if your theme is ready. Just be aware that we will ask you to adjust to v6 at some point to keep it included.
The theme is ready. I went through many times and I think that I covered everything I possibly could (base visual, responsiveness, tables, popups, alerts, messages, overheating warning, updates available, submenus, pickers, etc...). So far it worked well for me and I didn't have any complaints/issues reported. But of course edge cases exists ...
Just be aware that we will ask you to adjust to v6 at some point to keep it included.
I'm planning to keep it up to date. That's why I was asking about the development process. I have to try to run it in the Docker to have a separate version. As for this moment I run it on Raspberry and I'm using custom script in the browser to inject the local styles directly.
Firstly, I want to express my appreciation for the time and effort you've dedicated to creating this fantastic theme. I was so impressed that I took the initiative to share it on Reddit. The response has been overwhelmingly positive, and it's evident that many people love your work as much as I do. I've even shared the Next Generation theme on Reddit!
I do have a couple of questions, however:
Is there a way to set the theme to auto-update?
If not, could you guide me on the proper method for updating the theme? At the moment, I'm deleting the current installation and then reinstalling it. The issue with this approach is that I can't easily tell which version of the theme I currently have installed.
I want to extend my sincere gratitude for the theme you made; it's aesthetically pleasing, and the animations are particularly engaging. And don't want to be the person picking the little things and complain. However, today I've stumbled upon a situation that seems to hint at a possible conflict with my PiOLED by Adafruit.
I must admit, I'm no expert in coding or deciphering error messages, but since applying this theme. I noticed that the displaying isn't showing anything.
I tried to run the code sudo i2cdetect -y 1 and everything was fine. But upon running the code sudo python3 stats.py I'm getting error messages, and my PiOLED is unable to display anything. I am reaching out with hope that you, or someone proficient in this area, could provide some clarity or a remedy to this issue. It would be a great disappointment to revert to the original LCARS theme—while it worked fine, I have grown quite fond of the current one.
To give you a better understanding, I've followed the Adafruit guide meticulously and have attached the stats.py so that it displays on my PiOLED. But upon running the code sudo python3 /home/pi/stats.py & , I am encountering an error message that reads:
File "/home/pi/stats.py", line 116, in
DNSQUERIES = data['dns_queries_today']
TypeError: list indices must be integers or slices, not str
This error message has left me in a bind, and I'm quite unsure about the way forward. If there are any insights or solutions to address this issue and resume the functionality of the PiOLED with the preferred theme intact, it would be immensely appreciated.