Setting custom DNS, endless GUI spinner

chrislph · December 12, 2023, 11:23am

I just started testing v6. Going into Settings > DNS > Custom DNS servers, deselecting the two that were selected in the list, pasting in a couple of lines for custom external DNS servers and clicking Save & Apply. Page reloads and the (now all deselected) DNS servers list fails to load, just shows the spinner endlessly.

Manually reloading the page renders it correctly and shows it all worked okay.

*** No support needed, just feeding back in case useful.

Core
    Version is v5.17.1-253-g719ce801 (Latest: v5.17.2)
    Branch is development-v6
    Hash is 719ce801 (Latest: 719ce801)
Web
    Version is v5.19-592-ga0abbb5a (Latest: v5.21)
    Branch is development-v6
    Hash is a0abbb5a (Latest: a0abbb5a)
FTL
    Version is vDev-d6f13ac (Latest: v5.23)
    Branch is development-v6
    Hash is d6f13ac7 (Latest: d6f13ac7)

Firefox 120.0.1 (64-bit) on Mint Linux

https://tricorder.pi-hole.net/1AgX7Nd9/

DL6ER · December 12, 2023, 11:37am

I think this will be fixed by

github.com/pi-hole/web

Add progress reporting

development-v6 ← new/loading

opened 09:17AM - 14 Nov 23 UTC

DL6ER

+200 -4

# What does this implement/fix? Add a processing overlay when saving settings… and add general progress bar for 1. login, and 3. saving settings Example 1 (Login): ![ezgif-1-3e2f70a01a](https://github.com/pi-hole/web/assets/16748619/df963b53-3bf3-4f68-be33-4a4eb9e44ecf) Example 2 (applying settings): ![ezgif-1-c42ee8e7be](https://github.com/pi-hole/web/assets/16748619/41d50dd1-c8fa-411b-b821-5ee5efbc369b) I would like to get some opinions: What is your general mood about this change? (in categories useless, hate it, like it, love it) The timeout for the login is already dynamic (it takes as long as it takes) but the timeout for the settings is currently a hard-wired delay of 4 seconds (for demonstration purposes). We can make this dynamic by having FTL measure how long a restart really takes on a machine and sending this in the JSON response for using here. **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 5. I have commented my proposed changes within the code. 6. I am willing to help maintain this change if there are issues with it later. 7. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 8. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.

and is kind of a race collision with FTL restarting due to the DNS server change.

chrislph · December 12, 2023, 12:08pm

Nice one, I'll track the observation and report if this fixes it here.

Is it okay to provide non-support feedback about all aspects of v6 in here? I created a feedback tag to help separate them.

DL6ER · December 12, 2023, 6:28pm

Absolutely! We love to see everything you have for us.