whole
March 13, 2024, 9:57pm
1
Perhaps I'm not familiar with the new interface in Phole 6.
Where would I look for the search field in the Query Log? The Advanced Filtering doesn't search as you type even if the Live Update is refreshed
in v5 there was a search field and it would search or filter as you type
DL6ER
March 14, 2024, 6:49pm
4
We implemented server-side pagination and - apparently - searching was indeed lost on the way. Please check if this suites your needs:
pi-hole:development-v6
← pi-hole:new/query_log_search
opened 06:42PM - 14 Mar 24 UTC
# What does this implement/fix?
See title. Wildcards (*) are supported everyw… here in the search string.
>[!IMPORTANT]
>This PR depends on FTL PR #TBD
## Example 1: Simple partial matching
![Screenshot from 2024-03-14 19-37-15](https://github.com/pi-hole/web/assets/16748619/5f1438e8-61c1-4535-8599-12876cd3a3b5)
## Example 2: Using multiple wildcards
![Screenshot from 2024-03-14 19-37-33](https://github.com/pi-hole/web/assets/16748619/7a567276-f27f-4e43-8e3b-c2581d3bbcf7)
## Example 3: Combined search
![Screenshot from 2024-03-14 19-37-45](https://github.com/pi-hole/web/assets/16748619/0519357e-ac8f-4314-ac4f-3541d7736bd5)
---
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
pi-hole:development-v6
← pi-hole:new/query_log_search
opened 06:46PM - 14 Mar 24 UTC
# What does this implement/fix?
Add searching for domains and clients in the … Query Log. Wildcards (*) are supported everywhere in the search string.
>[!NOTE]
> See https://github.com/pi-hole/web/pull/2980 for further details.
We do not add documentation to the API as this PR merely implements yet another piece of the extremely extensive server-side processing specification of [DataTables](https://datatables.net/).
---
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
1 Like
whole
March 14, 2024, 8:54pm
5
Got it, no worries
Thank you for adding this to the feature requests
DL6ER
March 15, 2024, 4:18pm
6
This feature is now available in development-v6
1 Like