Root zone `.` can't be excluded from the top lists

armujahid · September 18, 2022, 4:58pm

This would be very useful. As you can see below my top permitted domain is . which I want to hide/ignore without blocking it

Related: Single dot domain/DNS root zone query issue with containerized wireguard

jfb · September 18, 2022, 6:06pm

Use the top lists section of the web admin GUI > settings > API/Web Interface to exclude this domain from your top list(s).

armujahid · September 19, 2022, 4:07pm

Unable to add dot as top domain exclusion list. Getting this error
"Top Domains/Ads entry . is invalid (use only domains)!
The settings have been reset to their previous values "

yubiuser · September 19, 2022, 8:30pm

I've moved your posts to a new thread.

Not being able to exclude . from the top lists is a bug. I'll fix that.

yubiuser · September 20, 2022, 2:21pm

github.com/pi-hole/AdminLTE

Allow the root zone `.` to be excluded from top lists

pi-hole:devel ← pi-hole:tweak/top_root

opened 02:21PM - 20 Sep 22 UTC

yubiuser

+4 -0

**What does this PR aim to accomplish?:** Allows the root zone (`.`) to be ex…cluded form the dashboard's top list. See discourse discussion here: https://discourse.pi-hole.net/t/root-zone-cant-be-excluded-from-the-top-lists/58043 In `savesettings.php` we check every domain with `validDomainWildcard` from `func.php`. This PR adds a bypass of those checks for the root zone. https://github.com/pi-hole/AdminLTE/blob/b110eccceac2473697f8fac59e5de5d12c08c56e/scripts/pi-hole/php/savesettings.php#L365-L374 https://github.com/pi-hole/AdminLTE/blob/b110eccceac2473697f8fac59e5de5d12c08c56e/scripts/pi-hole/php/func.php#L46-L54 --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code and I have tested my changes. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- - [x] I have read the above and my PR is ready for review. _Check this box to confirm_

system · October 11, 2022, 2:22pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.