Resolve client IP-Adresses for the Long Term Data section

netred · May 26, 2022, 5:52pm

The "real time" query list shows resolved client names instead of ip adresses.
The Long Term Data menu option does only show the ip adresses , both for the query log and the top lists.
This is not consistent and i'd like to see the name of the client instead.

yubiuser · May 31, 2022, 5:30am

github.com/pi-hole/FTL

Keep Query Log details across FTL restart

pi-hole:development ← pi-hole:new/database_reply_replytime_dnssec

opened 08:23PM - 19 Jan 22 UTC

DL6ER

+122 -11

**By submitting this pull request, I confirm the following:** - [X] I have re…ad and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). - [X] I have checked that [another pull request](https://github.com/pi-hole/FTL/pulls) for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **How familiar are you with the codebase?:** ## 10 --- When restarting FTL, it imports history from the database to repopulate the history. So far, this was only possible with a reduced set of variables to keep the database from growing forever. Recent database optimizations https://github.com/pi-hole/FTL/pull/1255 reduced the database size significantly allowing us to store more data in the database. This PR adds storing all the details necessary for the query log so a restart goes (almost) invisible and without any data loss. *) almost because some queries may not have been completed due to the forced restart and according service interruption.

github.com/pi-hole/AdminLTE

Show all available data on Long-term data query log page

pi-hole:devel ← pi-hole:fix/issue2149

opened 10:18PM - 15 May 22 UTC

rdwebdesign

+113 -28

**By submitting this pull request, I confirm the following:** - [x] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template. - [x] I have made only one major change in my proposed changes. - [x] I have commented my proposed changes within the code. - [x] I have tested my proposed changes. - [x] I am willing to help maintain this change if there are issues with it later. - [x] I give this submission freely and claim no ownership. - [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) - [x] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff)) --- **What does this PR aim to accomplish?:** Fix #2149. **How does this PR accomplish the above?:** Add missing columns `reply_type`, `reply_time`, `dnssec` to the query log table. **What documentation changes (if any) are needed to support this PR?:** none

github.com/pi-hole/AdminLTE

Show names in top clients list from long-term data

pi-hole:devel ← pi-hole:db_toplist_names

opened 06:53PM - 04 Jul 22 UTC

yubiuser

+5 -1

- **What does this PR aim to accomplish?:** Replaces the IPs in the Top Clien…ts list (in long-term data) with names if applicable. Since https://github.com/pi-hole/FTL/pull/1255 we store more data in the long-term database, e.g. the name of the client which made the query. We can use that to fetch the name when generating the top list. ![Bildschirmfoto zu 2022-07-04 20-43-05](https://user-images.githubusercontent.com/26622301/177205972-e50ef73f-2942-4bfc-b760-3fae7c18da84.png) - **How does this PR accomplish the above?:** Re-uses the code from https://github.com/pi-hole/AdminLTE/pull/2202 to get the name of the client if one is set. --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code and I have tested my changes. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- - [x] I have read the above and my PR is ready for review. _Check this box to confirm_

yubiuser · July 8, 2022, 9:33pm

Released with Pi-hole FTL v5.16, Web v5.13 and Core v5.11.1 released