Request: Ability to add clients to known client list from Network page

[gpb]

Thanks @DL6ER.

[yubiuser]

Thanks for the implementation but I just wanted to ask again what you think about removing the arp flush from the WEB "Flush network table"?
I still think it is a potential source of false-positive mock devices by the mechanism I described above.

@yubiuser

host makes query (APR and FTL know about), flush network table (ARP is empty, FTL still knows), no further query is made, network table is updated (only FTL knows -> mock device), host makes query (APR and FTL know), network table is updated (as ARP knows the device -> duplicate real device is added

I had a look in the code and the relevant section is in pi-hole/advanced/Scripts/piholeARPTable.sh

# Flush ARP cache to avoid re-adding of dead entries
    if ! output=$(ip neigh flush all 2>&1); then
        echo -e "${OVER}  ${CROSS} Failed to clear ARP cache"
        echo "  Output: ${output}"
        return 1

[DL6ER]

Thanks for reminding me.

Do not flush neigh cache

edit Merged