Request: Ability to add clients to known client list from Network page

Maybe @gpb can help us out by doing some more testing?

I suggest:

  • Checkout pihole checkout ftl new/all_clients_network_table_no-auto
  • flush network table by sudo sqlite3 /etc/pihole/pihole-FTL.db "DELETE FROM network; DELETE FROM network_addresses;"
  • see if duplicates popup
  • additionally: look in ip neigh at the time the first false-positives pop up to narrow down the issue

Furthermore:

  • Keep the commit for non-adding of the incomplete or failed as it will prevent addition of false-positives when we keep the transformation commit (and a device is longer > limit with incomplete ARP)
  • Keep the transformation commit as it is useful for edge cases where we don't know why same-subnet devices have no ARP entry at all (but might have a few minutes later)
  • Modify the GUI button