Redback
November 12, 2023, 12:22pm
1
I have been testing the new pi-hole-v6 on a VirtualBox with Slax as the OS. I believe I encountered an error where the search fails because of the incorrect dates, which were set by the filter when one requested “All Time” in the advance filter. I'd have expected it to be chronological, spanning the time of its creation to the present.
Core vDev (development-v6, 834e52f1)
What did you see? The result is not inside the selected time range? The results are out of order?
DL6ER
November 12, 2023, 8:22pm
4
Thanks for your report, will be fixed by
pi-hole:development-v6 ← pi-hole:fix/query_log_all_time
opened 08:22PM - 12 Nov 23 UTC
# What does this implement/fix?
See title. When you click on "All Time", you … will get on branch ...
`development-v6`:
this branch:
The fix is simply mutiplying the current constants by 1000 because [Javascript](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now) thinks milliseconds are a good unit for timestamps...
This issue was first reported on Discourse
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
DL6ER
November 12, 2023, 8:29pm
5
This has already been reviewed + merged so this bug should be fixed in the latest development-v6 version
Redback
November 13, 2023, 11:21am
7
I have discovered several bugs, which I will upload with accompanying images.
In the Advance Filter sections, again another bug is the drop menu which is non-functional as shown in the image with the circle around the issue, it appears after opening the pi-hole page and navigate to the filter advance section.
Redback
November 13, 2023, 12:37pm
8
Another issue that has been identified in the Advanced Filter section.
Date issue, the years are way out of timeline, as shown in the image.
Cheers
This was a regression added by the PR linked above. Both should be fixed by Fix inital date/time by yubiuser · Pull Request #2828 · pi-hole/web · GitHub
Redback
November 13, 2023, 1:17pm
10
I updated Pi-hole last night, but there might be a problem with the updating as well.
Redback
November 13, 2023, 1:24pm
11
When I update pi-hole last night, all went well with no error or issues, however when I checked the Pi-hole version in the browser with the terminal Pi-hole version, one failed to update. And yet the Pihole -up done all three !
DL6ER
November 13, 2023, 9:10pm
13
At the time of your post, indeed another commit was more recent:
This seems to have been a rare race-collision where a build from an older commit took longer and overwrote the more recent binaries in the bucket. This is unfortunate but can never 100% be ruled out in branches with lots of movements.
Redback
November 16, 2023, 5:30pm
14
Thank you for letting me know, it has all cleared up, you guys have done a fantastic job on the V6.
