DL6ER
October 18, 2023, 5:00pm
5
In v5.x you first had to get all data and all processing worked in your local browser. For v6 we implemented server-side pagination which - so far - wasn't able to do wildcard matching. This has just been added in
pi-hole:development-v6 ← pi-hole:new/query_log_wildcards
opened 04:59PM - 18 Oct 23 UTC
# What does this implement/fix?
Add wildcard support for server-side Query Lo… g for the fields `domain`, `client-ip`, `client-by-name`, and `upstream` and fix a minor glitch resulting in showing the total number of queries in the last 24 hours even when the timerange was narrowed down.
Instead of the completely random wildcard matching, we decided to opt for "real" wildcards with the wildcard character `*`. You can get anything ending in `google.com` - for instance, `analytics.google.com` - by searching for `*google.com` (hint: It'd also match `google.com` itself). But the wildcard implementation presented here goes beyond that, you can use a wildcard in any place you want: `*fla*.c*` will match `cloudflare.com`, `flamewar.com` and others.
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
Instead of the completely random wildcard matching, we decided to opt for "real" wildcards with the wildcard character *. So what you want could be achieved with *google.com (hint: It'd also match google.com itself). But our wildcard implementation goes beyond that, you can use a wildcard in any place you want: *fla*.c* will match cloudflare.com, flamewar.com and others.