b4sh
December 25, 2023, 3:20pm
1
#Everything is blocked but the display is not correct
Core vDev (development-v6, 6e8029f6)FTL vDev (development-v6, 07c403a3)Web interface vDev (development-v6, c5c2c5b7)
#Groups cannot be deleted
b4sh:
There is something wrong. You have zero domains on your lists.
Please upload a debug log and post just the token URL that is generated after the log is uploaded by running the following command from the Pi-hole host terminal:
pihole -d
DL6ER
December 25, 2023, 9:22pm
4
There is another error causing this. However, it is unfortunately hidden by the not very useful "cannot rollback" error message. This one is removed in
pi-hole:development-v6 ← pi-hole:tweak/rollback_error
opened 09:20PM - 25 Dec 23 UTC
# What does this implement/fix?
Do not check errors on `ROLLBACK TRANSACTION`… when `gravityDB_delFromTable()` fails. We remove this to avoid overwriting the initial cause of the error. See linked Discourse thread for context.
Additional context from [the SQLite3 documentation](https://www.sqlite.org/lang_transaction.html):
> [!TIP]
> 3. Response To Errors Within A Transaction
>
> If certain kinds of errors occur within a transaction, the transaction may or may not be rolled back automatically. The errors that can cause an automatic rollback include:
>
> * [SQLITE_FULL](https://www.sqlite.org/rescode.html#full): database or disk full
> * [SQLITE_IOERR](https://www.sqlite.org/rescode.html#ioerr): disk I/O error
> * [SQLITE_BUSY](https://www.sqlite.org/rescode.html#busy): database in use by another process
> * [SQLITE_NOMEM](https://www.sqlite.org/rescode.html#nomem): out of memory
>
> For all of these errors, SQLite attempts to undo just the one statement it was working on and leave changes from prior statements within the same transaction intact and continue with the transaction. However, depending on the statement being evaluated and the point at which the error occurs, it might be necessary for SQLite to rollback and cancel the entire transaction. An application can tell which course of action SQLite took by using the [sqlite3_get_autocommit()](https://www.sqlite.org/c3ref/get_autocommit.html) C-language interface.
>
> **It is recommended that applications respond to the errors listed above by explicitly issuing a ROLLBACK command.** If the transaction has already been rolled back automatically by the error response, then the ROLLBACK command will fail with an error, but no harm is caused by this.
>
> Future versions of SQLite may extend the list of errors which might cause automatic transaction rollback. Future versions of SQLite might change the error response. In particular, we may choose to simplify the interface in future versions of SQLite by causing the errors above to force an unconditional rollback.
---
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
For the rest, please generate the debug token as already asked for.
b4sh
December 27, 2023, 7:43am
7
b4sh
December 29, 2023, 1:30pm
9
There is no restart pi-hole button either
