PiHole updates to the same version

Help
1

Expected Behaviour:

Once PiHole detects a new version and updates, it should retain that version info and not keep updating.

Actual Behaviour:

PiHole keeps updating to the same version. Nothing is broken, just an annoyance. This started happening today.

I am on version:

  Current Pi-hole version is v5.6
  Current AdminLTE version is v5.8
  Current FTL version is v5.11

When I check for an update, I see:

  [i] Checking for updates...
  [i] Pi-hole Core:	update available
  [i] Web Interface:	up to date
  [i] FTL:		up to date

Once the update finishes, I am at the same version:

Update Complete!

  Current Pi-hole version is v5.6
  Current AdminLTE version is v5.8
  Current FTL version is v5.11

Debug Token:

d69suWQX

1 Like
2

oh i just posted similar, noticed only just started today, everytime i run -up it says an update davailiabel but stays on 5.6

cheers

*edit I deleted mine to try keep it in your thread

1 Like
3

This problem started after an update notification from github, title [pi-hole/AdminLTE] Release v5.9 - vNext:

vNext
Repository: pi-hole/AdminLTE · Tag: v5.9 · Commit: ee50954 · Released by: PromoFaux
•	Fix date ranges in datarangepicker in long-term data #1940 by @yubiuser
•	Fix dashboard icon animations in Safari #1939 by @Iksas
•	Set stateDuration to 0 for all saved datatables to store the state indefinitely #1944 by @yubiuser
•	Tweak to datatables column rendering #1948 @PromoFaux
•	Add missing blocked boolean in queries.js #1950 @DylanSealy
•	Add Star Trek LCARS theme #1936 @rdwebdesign
•	Queryads single DIV and responsive CSS (fixed) #1952 @rdwebdesign
•	Add missing rel="noopener" attributes #1956 @DylanSealy
•	Sidebar and nav-tab-custom: additional CSS for focus state #1955 @rdwebdesign
•	Allowing data loading after selecting/deselecting options - Long-term data > Query Log #1957 @rdwebdesign
•	fix: exclude status checkboxes from being treated as iCheck elements #1910 @lionralfs
•	Long-term graph changes #1969 @rdwebdesign
•	small typo in IP_ADDPRESS_OF_YOUR_PI_HOLE; two minor copy tweaks #1972 @Homesteady
•	Add pretty-printing for message type DNSMASQ_WARN #1973 @DL6ER
•	Fix the icon position (login password field) #1974 @rdwebdesign
•	Improving the display of some graphics #1976 @rdwebdesign
•	Swaping bar colors on "db_lists.js". #1981 @rdwebdesign
•	Use theme gridColor and ticksColor in long time graph #1977 @yubiuser
•	Remove traces of leftover API_PRIVACY_MODE #1943 @yubiuser
•	Redo of Fixes background of the dark-midnight theme #1961 #1966 @yubiuser @xopez
•	Fix PHP 8 incompatibility on settings page #1970 @DL6ER
•	Add message types LOAD, SHMEM and DISK to Pi-hole diagnosis system #1989 @DL6ER
•	Add bounce animation to Pi-hole diagnosis warning triangle #1990 @DL6ER
•	Change default theme to auto light/dark theme #2006 @yubiuser
—
This release has 2 assets:
•	Source code (zip)
•	Source code (tar.gz)
Visit the release page to download them.
—
You are receiving this because you are watching this repository.
View it on GitHub or unsubscribe from all notifications for this repository.
4

Two independent things happend yesterday:

  1. The release notes for an upcoming web update were released accidentally. As soon as we noticed it, we removed the message. No real code change happend.

  2. We updated the core repo with an internal PR for some GitHub actions. No Pi-hole specific code changes were included. However, due to how the update notification system works, your Pi-hole installation noticed a change in the repo and updated it locally as well. As we did not release a new version, after the update the version stayed at v5.6

1 Like
5

Thanks for the insights. Is there something we need to do to fix? Otherwise if the update check keeps updating to the same version, it is disorienting.

6

When there are new releases, we post a blog about it, which is linked here, Reddit, and twitter (and sometime Facebook when I remember that exists) if there isn't a blog post, there isn't a release :slight_smile:

My understanding was that a push to the master branch would not cause the update checker to detect changes - as it should work on tags - and core repo was not tagged. Might need to look at this if I get time at lunch

Web repo tag was an accident, and it was deleted within 20 seconds of it being created.

7

But anyone checking for an update is getting this error, so there is something that changed and flowed downstream and is still active.

Again, not a huge issue, just an annoyance.

8

I have the same problem / annoyance:

Update carried out:

pihole1
pihole1298×113 19.3 KB

Then the update message again:

pihole2
pihole2582×196 52.6 KB

1 Like
9

I've run into the same issue. Running pihole -up multiple times after each other results in updating every time.

I'd imagine that if for some reason the update checker detects changes because of an additional commit, even though it should work on tags, it updates itself to the same version over and over again. It pulls the last tagged release instead of that additional commit, so it ends up updating itself to a state where there's already an update.

10

For anyone still running into this, you can fix it this way.

cd /etc/.pihole
sudo git reset --hard origin
3 Likes
11

Works !

12

@Pi-hole devs, is this expected or okay to do?

Any ideas why this would need to be done all of a sudden? It seems the issue showed up right after the two independent actions that @yubiuser mentioned. Though I agree to seems strange that either of those actions would have caused this to happen…

I am also seeing this issue on multiple Pi-hole installs running the same latest versions.

13

Sure, it's fine.

14

I also ran into this problem of constant updates.

Nope, the update checker runs on commits, not tags.

GitCheckUpdateAvail() in /opt/pihole/update.sh compares local and remote commits (git rev-parse @{0}).

But the update mechanism (update_repo in basic_install.sh) resets the downloaded repo to the latest tag.

Hence the constant (non-)updates, when there are commits on the master branch newer than the latest tag.

1 Like
15

Thank you very much for posting this.

16

Thanks for the info. I was wondering why I was getting cron emails about the same # pihole -up job running every night with the same results.

17

This should be sorted in the next release - but I would heavily advise against having pihole -up running on a cron job. For all the same reasons we do not advise users update Pi-hole running in docker using watchtower (See release notes for :2021.09)

18

Excellent advice, and normally I'd agree. But with a family, 11 machines, and a bunch of other things to admin, automation has been the way forward for me. I just don't have the time to manually oversee updates unless I absolutely have to nowadays. FWIW, I've had unattended-upgrades running just fine on Debian, Raspberry Pi OS, and Ubuntu for nearly 2 years now, in addition to dnscrypt-proxy updating itself via a script on the same machine Pi-hole runs on.

Purely from my own experience, I face a bigger risk from not rapidly updating than I do from an update breaking my systems. This is in large part due to me coloring within the lines (example) for each OS I run.

1 Like
20

We've just released a new update so this should now stop happening.

We also included a change to check for updates based on tag rather than commit : https://github.com/pi-hole/pi-hole/pull/4475

21

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.