Bmooij
June 13, 2018, 4:22pm
1
On a mobile device, the current pi-hole and web interface version are not visible. Also on a mobile device there is no hint that a new version is available.
Will be implemented in v5.1
pi-hole:devel ← pi-hole:tweak-footer
opened 05:14PM - 21 May 20 UTC
**By submitting this pull request, I confirm the following:** `{please fill any … appropriate checkboxes, e.g: [X]}`
`{Please ensure that your pull request is for the 'devel' branch!}`
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [ ] I have commented my proposed changes within the code.
- [x] I have tested my proposed changes.
- [x] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
- [x] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff))
---
I tested it as much as I could, but the more eyes the better 🙂
vDev:
<img src="https://user-images.githubusercontent.com/349621/82585596-e8bc1600-9b9e-11ea-80ff-0028862d6b36.png" alt="1-vdev" width="450">
---
master with updates:
<img src="https://user-images.githubusercontent.com/349621/82585603-ec4f9d00-9b9e-11ea-8dcb-9393267c2882.png" alt="2-updates" width="450">
Generated HTML beautified for demonstration purposes:
```html
<footer class="main-footer">
<div class="row row-centered text-center">
<div class="col-xs-12 col-sm-6">
<strong><a href="https://pi-hole.net/donate/" rel="noopener" target="_blank"><i class="fa fa-heart text-red"></i> Donate</a></strong> if you found this useful.
</div>
</div>
<div class="row row-centered text-center version-info">
<div class="col-xs-12 col-sm-8 col-md-6">
<ul class="list-inline">
<li>
<strong>Pi-hole Version</strong>
<a href="https://github.com/pi-hole/pi-hole/releases/v5.0" rel="noopener" target="_blank">v5.0</a>
· <a href="https://github.com/pi-hole/pi-hole/releases/latest" rel="noopener" target="_blank" class="alert-link lookatme">Update available!</a>
</li>
<li>
<strong>Web Interface Version</strong>
<a href="https://github.com/pi-hole/AdminLTE/releases/v5.0" rel="noopener" target="_blank">v5.0</a>
· <a class="lookatme" href="https://github.com/pi-hole/AdminLTE/releases/latest" rel="noopener" target="_blank">Update available!</a>
</li>
<li>
<strong>FTL Version</strong>
<a href="https://github.com/pi-hole/FTL/releases/v5.0" rel="noopener" target="_blank">v5.0</a>
· <a class="lookatme" href="https://github.com/pi-hole/FTL/releases/latest" rel="noopener" target="_blank">Update available!</a>
</li>
</ul>
</div>
</div>
</footer>
```
We could even link to the devel commits but I thought I'd leave this for later.