Please follow the below template, it will help us to help you!
Expected Behaviour:
I have Pi hole setup on my Edgerouter-X as DNS1 so all clients should be pointed to pihole for DNS
Actual Behaviour:
When I login to my pihole GUI, it shows only 2 clients. 192.168.1.1 which is my router and localhost. Is that normal or should I see all client IP's as well? It's my first time using pihole so I just want to be sure it's working correctly.
Your observation would be perfectly normal if you configure your router to use Pi-hole as its upstream DNS server (commonly a WAN/Internet setting).
It would be preferable to have your router distribute Pi-hole as local DNS server via DHCP, as that would allow you to attribute DNS traffic shown in Pi-hole's Query Log to individual clients.
Not all router models support that, though.
Pi-hole's Post Install documentation provides an overview and has links to further options and details.
It's already doing that. Under DHCP DNS for clients is set to 192.168.1.1 and under system in the edgerouter x DNS #1 is set to the Pi hole ip so a client should get routed to 192.168.1.1 first, the to the pihole 192.168.1.10 or at least I think thats how it shoudl work