would it be possible to include PADD in v6 as pihole -c
(where Chronometer used to live)?
current output from pihole -c
on v6-beta
Chronometer is gone, use PADD (https://github.com/pi-hole/PADD)
edit:
just noticed this as well
If you're running Pi-hole in the official Docker Container, padd.sh
is pre-installed and named padd
. It can be used with the following command:
docker exec -it <container_name> padd [padd_options]
why not include with bare metal install too?
Mhh... it's a bit tricky as it lives in an other repo on Github. We would need to download it separately during the installation. I think it's fine to leave it in its own repo as not everybody needs it and it makes development of PADD independent of Pi-hole.
1 Like
i made an attempt at this
development
← mwoolweaver:tweak/add-PADD-for-chronometer
opened 06:56PM - 12 Mar 25 UTC
**What does this PR aim to accomplish?:**
add PADD as the successor to Chrono… meter instead of the current message that is shown when running `pihole -c`
if calculated correctly these changes would only increase the storage footprint of Pi-hole on bare metal installs by less than 1.5MB
```
du -hs /etc/.padd /usr/local/bin/padd
1.3M /etc/.padd
80K /usr/local/bin/padd
```
**How does this PR accomplish the above?:**
1. adds `https://github.com/pi-hole/PADD.git` as `paddGitUrl` and `/etc/.padd/` as `PADD_LOCAL_REPO` to `automated install/basic-install.sh` as global variables for use as seen in the following steps.
2. extends functionality of `clone_or_reset_repos()` to clone `paddGitUrl` to `PADD_LOCAL_REPO`.
3. extends functionality of `installScripts()` to install `${PADD_LOCAL_REPO}/padd.sh` as `${PI_HOLE_BIN_DIR}/padd`, in the same location as [pi-hole/docker-pi-hole](https://github.com/pi-hole/docker-pi-hole/blob/78aee9e4b2089263359d6d7e2847028f237b7aef/src/Dockerfile#L57), which should allow part 3 to work on bare metal and docker.
4. links `pihole -c` (`paddFunc()`, formerly ``chronometerFunc()``) to `${PI_HOLE_BIN_DIR}/padd` and ensures first argument is dropped before starting, which is likely to be `-c` since `padd` is being started with `pihole -c`.
5. extends functionality of `checkout()`, `advanced/Scripts/update.sh`, and `advanced/Scripts/updatecheck.sh` to ensure PADD is updated accordingly.
6. extends functionality of `advanced/Scripts/version.sh` to ensure PADD version is shown.
7. ensures PADD is completely removed during uninstall.
_hopefully i did not miss anything_ if so please let me know
**Link documentation PRs if any are needed to support this PR:**
pi-hole/docs/pull/1209
adds PADD between Tail and Gravity where Chronometer was in v5 docs.
```
### PADD
| | |
| -------------- | -------------- |
| Help Command | `pihole -c --help` or `padd --help` |
| Script Location | [`/usr/local/bin/padd`](https://github.com/pi-hole/PADD/blob/master/padd.sh) |
| Example Usage | [`pihole -c`](https://discourse.pi-hole.net/t/the-pihole-command-with-examples/738#chronometer) or just `padd`|
PADD (formerly Chronometer2) is a more expansive version of the original chronometer.sh that was included with Pi-Hole. PADD provides in-depth information about your Pi-hole.
```
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
8. I am willing to help maintain this change if there are issues with it later.
9. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
10. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
11. I have checked that another pull request for this purpose does not exist.
12. I have considered, and confirmed that this submission will be valuable to others.
13. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
14. I give this submission freely, and claim no ownership to its content.
---
- [✓] I have read the above and my PR is ready for review.