/opt/pihole/updatecheck.sh: line 42: /etc/pihole/setupVars.conf: No such file or directory

yubiuser · July 22, 2022, 7:43am

To implement the check is easy - the question is why is it failing in the first place?

updatecheck is called during installation here:

automated%20install/basic-install.sh

aefbe1f5b


      
          # Force an update of the updatechecker
          /opt/pihole/updatecheck.sh
          /opt/pihole/updatecheck.sh x remote

However, setupVars.conf is written earlier:

github.com/pi-hole/pi-hole

automated%20install/basic-install.sh

aefbe1f5b


      
          local binary
          binary="pihole-FTL${funcOutput##*pihole-FTL}" #binary name will be the last line of the output of get_binary_name (it always begins with pihole-FTL)
          local theRest
          theRest="${funcOutput%pihole-FTL*}" # Print the rest of get_binary_name's output to display (cut out from first instance of "pihole-FTL")
          if ! FTLdetect "${binary}" "${theRest}"; then
              printf "  %b FTL Engine not installed\\n" "${CROSS}"
              exit 1
          fi
          
          # Install and log everything to a file
          installPihole | tee -a /proc/$$/fd/3
          
          # Copy the temp log file into final log location for storage
          copy_to_install_log
          
          if [[ "${INSTALL_WEB_INTERFACE}" == true ]]; then
              # Add password to web UI if there is none
              pw=""
              # If no password is set,
              if [[ $(grep 'WEBPASSWORD' -c "${setupVars}") == 0 ]] ; then
                  # generate a random password

github.com/pi-hole/pi-hole

automated%20install/basic-install.sh

aefbe1f5b


      
              installLogrotate || true
          
              # Check if dnsmasq is present. If so, disable it and back up any possible
              # config file
              disable_dnsmasq
          
              # install a man page entry for pihole
              install_manpage
          
              # Update setupvars.conf with any variables that may or may not have been changed during the install
              finalExports
          }
          
          # SELinux
          checkSelinux() {
              local DEFAULT_SELINUX
              local CURRENT_SELINUX
              local SELINUX_ENFORCING=0
              # Check for SELinux configuration file and getenforce command
              if [[ -f /etc/selinux/config ]] && is_command getenforce; then
                  # Check the default SELinux mode

github.com/pi-hole/pi-hole

automated%20install/basic-install.sh

aefbe1f5b


      
          {
              echo "PIHOLE_INTERFACE=${PIHOLE_INTERFACE}"
              echo "PIHOLE_DNS_1=${PIHOLE_DNS_1}"
              echo "PIHOLE_DNS_2=${PIHOLE_DNS_2}"
              echo "QUERY_LOGGING=${QUERY_LOGGING}"
              echo "INSTALL_WEB_SERVER=${INSTALL_WEB_SERVER}"
              echo "INSTALL_WEB_INTERFACE=${INSTALL_WEB_INTERFACE}"
              echo "LIGHTTPD_ENABLED=${LIGHTTPD_ENABLED}"
              echo "CACHE_SIZE=${CACHE_SIZE}"
              echo "DNS_FQDN_REQUIRED=${DNS_FQDN_REQUIRED:-true}"
              echo "DNS_BOGUS_PRIV=${DNS_BOGUS_PRIV:-true}"
              echo "DNSMASQ_LISTENING=${DNSMASQ_LISTENING:-local}"
          }>> "${setupVars}"
          chmod 644 "${setupVars}"