/opt/pihole/updatecheck.sh: line 42: /etc/pihole/setupVars.conf: No such file or directory

jpgpi250 · July 21, 2022, 10:30am

fresh pihole install (from scratch):
Pi-hole version is v5.11.4 (Latest: v5.11.4)
AdminLTE version is v5.13 (Latest: v5.13)
FTL version is v5.16.1 (Latest: v5.16.1)

/opt/pihole/updatecheck.sh: line 42: /etc/pihole/setupVars.conf: No such file or directory

lines 40 to 42:

# Source the setupvars config file
# shellcheck disable=SC1091
. /etc/pihole/setupVars.conf

yubiuser · July 21, 2022, 1:51pm

When do you see this message? During installation? Does the file exist?

jpgpi250 · July 21, 2022, 9:10pm

I got the mail with the error message at 11:50:06, the install log (/etc/pihole/install.log) change time is 11:50:11, so I asume this is something that happens during installation.

As soon as I read the message, I checked, the file does exist.
also, running updatecheck.sh manually, doesn't give this error.

In gravity.sh, you use the following code:

if [[ -f "${setupVars}" ]];then
  source "${setupVars}"
else
  echo -e "  ${COL_LIGHT_RED}Installation Failure: ${setupVars} does not exist! ${COL_NC}
  Please run 'pihole -r', and choose the 'reconfigure' option to fix."
  exit 1
fi

Might I ask the reason why you use a different approach in updatecheck.sh?

DanSchaper · July 21, 2022, 9:37pm

Probably no good reason.

yubiuser · July 22, 2022, 7:43am

To implement the check is easy - the question is why is it failing in the first place?

updatecheck is called during installation here:

github.com

pi-hole/pi-hole/blob/aefbe1f5b6225b7476fe08264c62da84aaa61fa0/automated install/basic-install.sh#L2834-L2836


      
          # Force an update of the updatechecker
          /opt/pihole/updatecheck.sh
          /opt/pihole/updatecheck.sh x remote

However, setupVars.conf is written earlier:

github.com

pi-hole/pi-hole/blob/aefbe1f5b6225b7476fe08264c62da84aaa61fa0/automated install/basic-install.sh#L2758


      
          local binary
          binary="pihole-FTL${funcOutput##*pihole-FTL}" #binary name will be the last line of the output of get_binary_name (it always begins with pihole-FTL)
          local theRest
          theRest="${funcOutput%pihole-FTL*}" # Print the rest of get_binary_name's output to display (cut out from first instance of "pihole-FTL")
          if ! FTLdetect "${binary}" "${theRest}"; then
              printf "  %b FTL Engine not installed\\n" "${CROSS}"
              exit 1
          fi
          
          
# Install and log everything to a file
          installPihole | tee -a /proc/$$/fd/3
          
          
# Copy the temp log file into final log location for storage
          copy_to_install_log
          
          
if [[ "${INSTALL_WEB_INTERFACE}" == true ]]; then
              # Add password to web UI if there is none
              pw=""
              # If no password is set,
              if [[ $(grep 'WEBPASSWORD' -c "${setupVars}") == 0 ]] ; then
                  # generate a random password

github.com

pi-hole/pi-hole/blob/aefbe1f5b6225b7476fe08264c62da84aaa61fa0/automated install/basic-install.sh#L2049


      
              installLogrotate || true
          
          
    # Check if dnsmasq is present. If so, disable it and back up any possible
              # config file
              disable_dnsmasq
          
          
    # install a man page entry for pihole
              install_manpage
          
          
    # Update setupvars.conf with any variables that may or may not have been changed during the install
              finalExports
          }
          
          
# SELinux
          checkSelinux() {
              local DEFAULT_SELINUX
              local CURRENT_SELINUX
              local SELINUX_ENFORCING=0
              # Check for SELinux configuration file and getenforce command
              if [[ -f /etc/selinux/config ]] && is_command getenforce; then
                  # Check the default SELinux mode

github.com

pi-hole/pi-hole/blob/aefbe1f5b6225b7476fe08264c62da84aaa61fa0/automated install/basic-install.sh#L1921-L1934


      
          {
              echo "PIHOLE_INTERFACE=${PIHOLE_INTERFACE}"
              echo "PIHOLE_DNS_1=${PIHOLE_DNS_1}"
              echo "PIHOLE_DNS_2=${PIHOLE_DNS_2}"
              echo "QUERY_LOGGING=${QUERY_LOGGING}"
              echo "INSTALL_WEB_SERVER=${INSTALL_WEB_SERVER}"
              echo "INSTALL_WEB_INTERFACE=${INSTALL_WEB_INTERFACE}"
              echo "LIGHTTPD_ENABLED=${LIGHTTPD_ENABLED}"
              echo "CACHE_SIZE=${CACHE_SIZE}"
              echo "DNS_FQDN_REQUIRED=${DNS_FQDN_REQUIRED:-true}"
              echo "DNS_BOGUS_PRIV=${DNS_BOGUS_PRIV:-true}"
              echo "DNSMASQ_LISTENING=${DNSMASQ_LISTENING:-local}"
          }>> "${setupVars}"
          chmod 644 "${setupVars}"

yubiuser · July 22, 2022, 7:49am

I think we could even remove sourcing setupVars.conf. It's only used to determine if the web interface has been installed during the installation. Instead, we could just check if /var/www/html/admin exists....

jpgpi250 · July 22, 2022, 7:55am

I came to the same conclusion as you did, this shouldn't be happening, and yet it did. It's a one of (no errors when running updatecheck later), but I thought it may be worth mentioning it, in case I missed something.

Feel free to close this topic.

good idea ...

system · July 29, 2022, 7:56am

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.