Looking to contribute code / OS validation to Pi-hole

mbrouil3 · July 27, 2026, 1:16am

Hello Pi-hole team & community!

I am looking to contribute to Pi-hole.

However, I am new-ish to contributing to open-source as a whole, so apologies in advance if I'm missing something that's blatantly obvious. I do have a GitHub, so I got that going for me

Back to brass tacks - I saw this post on "help with contributing" to pi-hole, which helped me a bit, but with it dated 2021 I figured a fresh post would be beneficial to the whole community.

To be clear, my objectives are to test, validate, and bring Pi-Hole compatibility to:

Ubuntu 26.04 and later LTS releases (this appears to be covered in this pull request unless I am mis-reading something)
openSUSE LEAP compatibility (Specifically LEAP and not Tumbleweed as the latter is a rolling release)

How and where can I get started?

rdwebdesign · July 27, 2026, 2:11am

The latest Pi-hole version is compatible with Ubuntu 26.
There are automatic tests for many Ubuntu versions, including 26: pi-hole/test at master · pi-hole/pi-hole · GitHub

In the past we discussed the possibility of adding this OS to the tests, but since no one from the team uses openSUSE, we are not comfortable about adding it to the officially supported OS list. We don't have time and resources to test Pi-hole on every possible OS.

I'm not saying we will never make it compatible to other operating systems (it would be nice to know if Pi-hole works on other operating systems. Maybe it is already compatible openSUSE). We just aren't able to guarantee it will always work.

You can start by trying to install Pi-hole in openSUSE and reporting your findings.

mbrouil3 · July 28, 2026, 2:38pm

Ah, so I did read the github pull request proper! Much appreciated!

Ok and that's exactly where I was going to start.

Now, where shall I report my findings, I assume GitHub? Or, Is a post in this discourse sufficient? Please point me in the correct direction. Appreciate your patience!

darkexplosiveqwx · July 28, 2026, 2:46pm

There have been previous attempts at SUSE compatibility: https://github.com/pi-hole/pi-hole/pull/5001, Make install script compatible with openSUSE by yubiuser · Pull Request #5083 · pi-hole/pi-hole · GitHub and most recently by me: Add support for opensuse leap 15.6 by darkexplosiveqwx · Pull Request #6200 · pi-hole/pi-hole · GitHub

I was trying out SUSE and decided to work on some support, but the PR died down once I stopped using it.

You may take them as inspiration and reference for your own work.

Even while Work-in-Progress, you may open a draft PR where we can give preliminary feedback if you want.

mbrouil3 · July 28, 2026, 4:55pm

Great to know and appreciate the resources!

I've already tried installing Pihole on opensuse16 however I'm running into selinux issues, which doesn't surprise me at all.

It's worth noting, that while SELinux is enabled by default on OpenSuSE, and is toggleable in the OS installer, my goal is to install pihole on a standard opensuse image....

Running basic-install.sh fails to recognize env variable PIHOLE_SELINUX=true, which I believe is a bug and as such I'll put in a PR request soon enough as per previous posts.

rdwebdesign · July 28, 2026, 6:49pm

Are you sure the variable is not recognized?

Maybe the issue is on the other SELINUX checks.

github.com/pi-hole/pi-hole

automated%20install/basic-install.sh

f47b8ede5


      
          if [[ -f /etc/selinux/config ]] && is_command getenforce; then
              # Check the default SELinux mode
              DEFAULT_SELINUX=$(awk -F= '/^SELINUX=/ {print $2}' /etc/selinux/config)
              case "${DEFAULT_SELINUX,,}" in
              enforcing)
                  printf "  %b %bDefault SELinux: %s%b\\n" "${CROSS}" "${COL_RED}" "${DEFAULT_SELINUX,,}" "${COL_NC}"
                  SELINUX_ENFORCING=1
                  ;;
              *) # 'permissive' and 'disabled'
                  printf "  %b %bDefault SELinux: %s%b\\n" "${TICK}" "${COL_GREEN}" "${DEFAULT_SELINUX,,}" "${COL_NC}"
                  ;;
              esac
              # Check the current state of SELinux
              CURRENT_SELINUX=$(getenforce)
              case "${CURRENT_SELINUX,,}" in
              enforcing)
                  printf "  %b %bCurrent SELinux: %s%b\\n" "${CROSS}" "${COL_RED}" "${CURRENT_SELINUX,,}" "${COL_NC}"
                  SELINUX_ENFORCING=1
                  ;;
              *) # 'permissive' and 'disabled'

This file has been truncated. show original

If the checks above fail, SELINUX_ENFORCING will never be set and the next if block will fail, even if PIHOLE_SELINUX=true variable is correctly set:

github.com/pi-hole/pi-hole

automated%20install/basic-install.sh

f47b8ede5


      
          if [[ "${SELINUX_ENFORCING}" -eq 1 ]] && [[ -z "${PIHOLE_SELINUX}" ]]; then
              printf "  Pi-hole does not provide an SELinux policy as the required changes modify the security of your system.\\n"
              printf "  Please refer to https://wiki.centos.org/HowTos/SELinux if SELinux is required for your deployment.\\n"
              printf "      This check can be skipped by setting the environment variable %bPIHOLE_SELINUX%b to %btrue%b\\n" "${COL_RED}" "${COL_NC}" "${COL_RED}" "${COL_NC}"
              printf "      e.g: export PIHOLE_SELINUX=true\\n"
              printf "      By setting this variable to true you acknowledge there may be issues with Pi-hole during or after the install\\n"
              printf "\\n  %bSELinux Enforcing detected, exiting installer%b\\n" "${COL_RED}" "${COL_NC}"
              exit 1
          elif [[ "${SELINUX_ENFORCING}" -eq 1 ]] && [[ -n "${PIHOLE_SELINUX}" ]]; then
              printf "  %b %bSELinux Enforcing detected%b. PIHOLE_SELINUX env variable set - installer will continue\\n" "${INFO}" "${COL_RED}" "${COL_NC}"
          fi

mbrouil3 · July 28, 2026, 7:08pm

Sorry, just seeing this now. I already opened a bug report on Github on the same.

I ran lines 1684, 1695 independently to verify as standard debug practice. Both show what I would expect, so I believe this is a bug.

mbrouil3@bossvcosslab2:\~> awk -F= '/^SELINUX=/ {print $2}' /etc/selinux/config 
enforcing 
mbrouil3@bossvcosslab2:\~> ls /etc/selinux/config 
/etc/selinux/config 
mbrouil3@bossvcosslab2:\~> getenforce 
Absolute path to 'getenforce' is '/usr/sbin/getenforce', so running it may require superuser privileges (eg. root). 
mbrouil3@bossvcosslab2:\~> sudo getenforce 
[sudo\] password for mbrouil3:  
Enforcing 
mbrouil3@bossvcosslab2:\~>

EDIT: I am already getting responses & feedback on my github bug report, so probably best to continue the conversation there vs here. I don't want to post the same thing in two different places if I can help it.