grdnwsl
January 26, 2020, 12:20am
1
Long regex lines break the new UI under 'Group Management -> Domains'. They push the drop-downs and other UI elements off to the right, but there's no scroll bar that appears at the bottom to be able to scroll right, making modification of the domain regex in question impossible.
Examples:
jfb
January 26, 2020, 12:52am
2
Short term fix : Go to web admin GUI > Settings > AOI/Web Interface > Web interface settings > Interface appearance : deselect "Used boxed layout..."
This will open up the screen window.
Long term fix : this fix branch will be incorporated into V5. You can get the branch now for testing by checking out this web branch.
pi-hole:release/v5.0
← pi-hole:tweak/responsive_group_tables
opened 08:02PM - 20 Jan 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fix issue brought up on Discourse: https://discourse.pi-hole.net/t/screen-adlist-group-management-on-ipad-air-2/27111
**How does this PR accomplish the above?:**
Add responsive class to new group tables to ensure they render properly on very narrow screens
**Before**
![Screenshot_2020-01-20 Pi-hole Admin Console(1)](https://user-images.githubusercontent.com/16748619/72754442-13ce3300-3bc8-11ea-8d03-286981a4b0e1.png)
**After**
![Screenshot_2020-01-20 Pi-hole Admin Console](https://user-images.githubusercontent.com/16748619/72754444-1597f680-3bc8-11ea-8127-d5611bc2046a.png)
**What documentation changes (if any) are needed to support this PR?:**
None
@grdnwsl that regex looks impressive/serious. Any chance you'd copy it into a reply for other folks to take a look at it?
DL6ER
January 27, 2020, 12:15pm
4
This has been merged and is now part of the regular beta.
Here you go:
(^|[-_.]+)(m?a(d((vert(s|is(ing|e?ments?))?|im(age|g)s?)|([vx]|s(e?rv(er?|ice)?s?)?)|track(ers?|ing))?|ff(iliat(es?|ion))?|nalytics?)|b((anner|eacon)s?)|count(ers?)?|pixels?|stat(s|istics?)?|t(elemetry|ra(ffic|ck(ers?|ing))))[-_]*[0-9]*[-_.]
Drop it in debuggex.com for a good visual representation of the match paths.