Local DNS Settings > x Invalid value

seh2000 · March 15, 2024, 5:15pm

Hi,
Wanted to add a device to the Local DNS Settings (used to work just fine a few weeks back) but keep keeping the Error message " x Invalid value / dns.hosts(0): invalid hostname (Viejo-Neveri")
Tried without the dash still same and same for other Domains and IPs.
Currently nothing is defined.

Core vDev (development-v6, 71b17294)
FTL vDev (development-v6, a0d65543)
Web interface vDev (development-v6, 240b3aaf)

https://tricorder.pi-hole.net/ciQpRhs9/

rdwebdesign · March 15, 2024, 6:37pm

Thanks for reporting the issue.

I can confirm this behavior, when using the recent development-v6 image.
Actually every value is considered invalid.

We need to investigate.

seh2000 · March 15, 2024, 6:40pm

You welcome
If need me to assist/help with let me know.

PromoFaux · March 16, 2024, 12:13am

Try viejo-neveri instead, confirmed that works on my test setup. It seems that the config validator is maybe a little too aggressive in this case and is rejecting it due to capital letters.

caps no caps

Paging @dl6er for thoughts.

The following line in the FTL domain validator suggests that we're expecting domains to be converted to lowercase before being parsed (suspect this is due to the function being borrowed from the gravity functionality)

github.com

pi-hole/FTL/blob/a0d655432af98e459b29921e59b7d7c3a97cb87a/src/tools/gravity-parseList.c#L57


      
          	if(domain == NULL || len == 0 || len > 255)
          		return false;
          
          	// Loop over line and check for invalid characters
          	int last_dot = -1;
          	for(unsigned int i = 0; i < len; i++)
          	{
          		// Domain must not contain any character other than [a-zA-Z0-9.-_]
          		if(domain[i] != '-' && domain[i] != '.' && domain[i] != '_' &&
          		   (domain[i] < 'a' || domain[i] > 'z') &&
          //		   (domain[i] < 'A' || domain[i] > 'Z') && // not needed as all domains are converted to lowercase
          		   (domain[i] < '0' || domain[i] > '9'))
          			return false;
          
          		// Individual label length check
          		if(domain[i] == '.')
          		{
          			// Label must be longer than 0 characters, i.e., two consecutive
          			// dots are not allowed
          			if(i - last_dot == 1)
          				return false;

I guess the answer is either one of:

Change web interface to convert the domain entered to lowercase
Change the API to convert the domain it receives to lowercase
Change FTL to accept upper case letters in a domain

Edit:

Easy PR if needed: Allow upper case letters in domains/hosts by PromoFaux · Pull Request #1910 · pi-hole/FTL · GitHub

DL6ER · March 16, 2024, 5:45am

The PR have been merged, @seh2000 could you update and verify the issue is gone?

seh2000 · March 16, 2024, 9:19am

Hi,
My bad - as I didn't check lower case, not sure why I forgot to try
I can confirm lower case works with current version.

image_2024-03-16_091751419

Core vDev (development-v6, 71b17294)FTL vDev (development-v6, a0d65543)Web interface vDev (development-v6, 240b3aaf)

seh2000 · March 16, 2024, 9:27am

Hello,
Confirming with latest update both upper and lower cases works.
Thanks