jfrico
September 13, 2020, 12:43pm
1
Is possible see in Ad list group management the number of domains has every list? And how many duplicates? For me is important to clear ad list that have only a little number of domains not duplicates.
You have this information when updates.
Wait you can understand I said. Sorry for my bad English.
Thanks,
jfb
September 13, 2020, 2:27pm
2
In Pi-hole V5 and later, duplicates among the various adlists are not removed. This keeps each adlist intact, so you can apply adlists to individual management groups.
I am not entirely sure I fully understand your intention, but if you would be looking for insights into your actual adlist utilisation (e.g. to help you decide whether to keep an adlist or not), I think a third-party utility like yubiuser 's adlist tool would be able to provide those.
Implementation is ongoing
pi-hole:development
← pi-hole:new/gravity_adlist_infos
opened 07:10AM - 28 Dec 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Store more gravity details in gravity.db adlist table for user display on the web interface
**How does this PR accomplish the above?:**
Store status of downloaded list (downloaded, using cache, some error,…) and number of (in-)valid domains on this list in the gravity database. This updates the gravity database to version 14.
**What documentation changes (if any) are needed to support this PR?:**
Gravity database schema changes, this needs to be accounted for in https://docs.pi-hole.net/database/gravity/groups/ in a follow-up PR.
pi-hole:devel
← pi-hole:new/gravity_adlist_infos
opened 07:11AM - 28 Dec 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Add more details to adlist table, exemplary screenshots:
![Screenshot from 2020-12-31 11-23-40](https://user-images.githubusercontent.com/16748619/103406699-ec177700-4b5b-11eb-8ecd-9bc1e4e50890.png)
Local lists do not get a link as they are not available for distant clients:
![Screenshot from 2020-12-31 11-23-50](https://user-images.githubusercontent.com/16748619/103406701-ee79d100-4b5b-11eb-9f11-c19becef3866.png)
**How does this PR accomplish the above?:**
Parse new data in the `gravity.db:adlist` table stored there by https://github.com/pi-hole/pi-hole/pull/3951
**What documentation changes (if any) are needed to support this PR?:**
None
This has been implemented.