Group Management AdList handling is bad

[GunerX]

Maybe I'm using this wrong (but I don't think I am), but this new "feature" (what was wrong with how it handled lists before? absolutely nothing) is total crap.

So here is an example of some URLs that need to be added to PiHoles list.

https://raw.githubusercontent.com/hectorm/hmirror/master/data/disconnect.me-ad/list.txt
https://raw.githubusercontent.com/hectorm/hmirror/master/data/disconnect.me-malvertising/list.txt
https://raw.githubusercontent.com/hectorm/hmirror/master/data/disconnect.me-malware/list.txt
https://raw.githubusercontent.com/hectorm/hmirror/master/data/disconnect.me-tracking/list.txt

Now, I am FORCED to go into Group Management -> Adlists in order to add these to the list. Sure. Fine. Go there, based purely on the text in the type bar before you type anything (see here: https://i.imgur.com/fT1HPkE.png ) the formate that you want is link, link, link,. Guess what. That doesn't work.

Here is the exact format I copy pasted into the bar.

https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.2o7net/list.txt,  https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.dead/list.txt,  https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.risk/list.txt,  https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.spam/list.txt

And here is the nice happy little error message I get: https://i.imgur.com/7cwkLFB.png

Ok. Maybe what you really ment was link , link , (notice the space inbetween the , ). Right? Surely thats it.

So lets try again with this format.

https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.2o7net/list.txt , 
https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.dead/list.txt , 
https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.risk/list.txt , 
https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.spam/list.txt

Lol nope. https://i.imgur.com/ko0oaF0.png

Now, you might be sitting there thinking "oh well clearly there is just something wrong with these links." LOL nope.

Lets try doing each link, one, by, one.

https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.2o7net/list.txt

This one results in an error. Ok. Cool. Good for you. You found a bad link. https://i.imgur.com/iJH0tTy.png

So......does that mean ALL the links are bad? No....

https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.dead/list.txt

The very next url in the list works just fine. Literally the Second URL. See here: https://i.imgur.com/6b5mT8P.png

But with the new Group Management Adlist "feature" it will just........stop.......at the first error. And not even TRY to do anything after that.

The previous method of adding Adlists worked flawlessly. You dump a huge list of URLs into it. It parses the list. Sometimes it finds errors, but it moves onto the next item in the list and continues until the entire list of URLs is done.

This new "feature" is 1 step forward 2 steps back. I am sitting here with a new list of Lists that has 102 URLs. I don't have time to sit here and copy paste 102 times while pressing "Add" each time. Thats unrealistic and quite frankly assenine.

Request return of previous superior "feature".

[PromoFaux]

Some work has already been done for the next release to clear up and possible missunderstanding on this page.

But the reason you are seeing the error is due to the , char you are putting in. The placeholder will be changed to clear up that confusion. But for what it's worth comma separated lists have never been supported.

To add them, you can copy a (new line + without the commas ) separated list and paste it in, and it will be converted to space separated, and thus parsed correctly.

Or you can add them all in with a space separating them.

[PromoFaux]

Here is a gif of the feature working quite adequately (and in the same way as it did previously )

edit:

The entry page in 5.1 will look like this:

[GunerX]

ok. but it still doesnt work.

https://raw.githubusercontent.com/hectorm/hmirror/master/data/eth-phishing-detect/list.txt https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.2o7net/list.txt https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.dead/list.txt https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.risk/list.txt https://raw.githubusercontent.com/hectorm/hmirror/master/data/fademind-add.spam/list.txt

still stops at the very First Error, and does not even try to add the next items in the list. https://i.imgur.com/LaDWRtS.png

the old method would just add them to the list (and no im not talking about 5.1, i updated from a much older version, i dont remember which, pretty sure it was 4.something)

I would really like the OLD method back. Let me just add ALL the urls in the list THEN you can figure out if some of them are wrong.

[PromoFaux]

5.1 is the new version that is not yet released.

For what it's worth I've just added the lists you have pasted with no issues.....:

The error you are now seeing is because you are attempting to add a list that already exists (the error being that it is hitting a UNIQUE constraint. Remove the duplicates and you will be able to add the lists.

That said, I acknowledge that this should probably not hard error at the point it detects a single duplicate, but I believe this is already raised as a bug and is being worked on.

Please moderate your tone, I appreciate that you've come across something that might not be working the way you expect it to, but there is no need for you to be making demands.