DL6ER
March 3, 2019, 9:25am
47
This is correct. In this case, we use the zero-address (AKA ::
).
We prepared a tweak for this which will suppress the creation of IPv6 blocking entries when IPV6_ADDRESS
is empty or unset. It will likely be released with the next version of FTL.
pi-hole:development
← pi-hole:fix/IP_blocking_empty_address
opened 09:24AM - 03 Mar 19 UTC
**By submitting this pull request, I confirm the following (please check boxes, … eg [X]) _Failure to fill the template will close your PR_:**
***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***
- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).
- [X] I have checked that [another pull request](https://github.com/pi-hole/FTL/pulls) for this purpose does not exist.
- [X] I have considered, and confirmed that this submission will be valuable to others.
- [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- [X] I give this submission freely, and claim no ownership to its content.
**How familiar are you with the codebase?:**
## 10
---
Don't create IPv6 cache entries when `IPV6_ADDRESS` is empty in `setupVars.conf`.
Currently, we create empty (`::`) IPv6 entries when users set `BLOCKINGMODE=IP` in `pihole-FTL.conf` when the `IPV6_ADDRESS` variable is empty (or unset) in `setupVars.conf`.
This PR ensures that IPv6 entries are not created in `IP` mode when we don't have a suitable address for them.
_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._