Expected Behaviour:
FTL to not update itself if it is already at the latest version
Actual Behaviour:
FTL updates to 5.3.4 every time I check for an update. It is already at that version
Debug Token:
tfothr3xn9
Known bug, fix already prepared
pi-hole:development ← pi-hole:fix/GitHubAPI
opened 09:48PM - 12 Jan 21 UTC
**By submitting this pull request, I confirm the following:**
*please fill any… appropriate checkboxes, e.g: [X]*
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [ ] I have commented my proposed changes within the code.
- [x] I have tested my proposed changes, and have included unit tests where possible.
- [x] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fixes #3986
GitHub API headers now have CSP with the work "location" in the policy. FTL tags came back with that location as the tag.
```text
dan@raspberrypi:~ $ curl -sI https://github.com/pi-hole/FTL/releases/latest | grep --color=never -i Location | awk -F / '{print $NF}' | tr -d '[:cntrl:]'
v5.3.4socket-worker-5029ae85.jsd
```
**How does this PR accomplish the above?:**
Only use `Locaition:` which should only grab the proper header.
```text
dan@raspberrypi:~ $ curl -sI https://github.com/pi-hole/FTL/releases/latest | grep --color=never -i Location: | awk -F / '{print $NF}' | tr -d '[:cntrl:]'
v5.3.4
```
1 Like
Hi yubiuser, thanks for the link however I'm having trouble understanding what to do. Do you know which parameter/code do I type in the cli? thanks
Bat
January 13, 2021, 11:45am
4
Hi,
minsik
January 13, 2021, 12:33pm
5
same, pihole says update available and goes through the full update procedure to only then display the same version.
jfb
January 13, 2021, 1:24pm
6
As noted in the pull request linked above, the Pi-hole code will be changed to fix this problem. The code will first be changed in the development branch, then that change will be incorporated into the next Pi-hole release. There is no schedule or estimated date for the next Pi-hole release.
In the meantime, ignore the error. It does not affect your Pi-hole operation. If you are on the latest release, you are set.
minsik
January 13, 2021, 10:34pm
7
thanks for the assurance update. Good work.
system
February 3, 2021, 10:34pm
8
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.
