Feedback for "Allow defining clients by their MAC address, host name and networking interface"

yubiuser · June 5, 2020, 8:06pm

I've seen that error before and Promo pushed an fix for this already some time ago.

github.com/pi-hole/web

Remove an error log output that was presumably leftover from debugging

pi-hole:devel ← pi-hole:tweak/notAnError

opened 04:02PM - 18 May 20 UTC

PromoFaux

+8 -4

**By submitting this pull request, I confirm the following:** - [x] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [x] I have made only one major change in my proposed changes. - [ ] I have commented my proposed changes within the code. - [x] I have tested my proposed changes, and have included unit tests where possible. - [x] I am willing to help maintain this change if there are issues with it later. - [x] I give this submission freely and claim no ownership. - [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** With this line, this gets printed to the error log every time the page is loaded, looks to just be debug output, I might be wrong! ``` 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: Array 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ( 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [default-light2] => Array 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ( 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [0] => Pi-hole default theme (light, default) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [1] => 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [2] => default-light 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [3] => minimal 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [4] => blue 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [default-dark] => Array 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ( 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [0] => Pi-hole midnight theme (dark) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [1] => 1 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [2] => default-dark 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [3] => polaris 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [4] => polaris 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [default-dark2] => Array 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ( 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [0] => Pi-hole afternoon theme (dark) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [1] => 1 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [2] => default-dark 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [3] => futurico 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: [4] => futurico 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ) 2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: ) ```