Update pushed to remove the double output.
Remove false-positive spotify.com
HorusTeknoloji:master
â lightswitch05:master
`spotify.com` is the legitimate website for the Spotify music streaming service.
Update pushed to remove the double output.
Agreed.
Most users will NOT even notice the errors, they install and forget, maybe add some lists, but as long as the count (blocked domains) is high enough, they probably never complain.
Thanks again, for your time and effort, have a good night sleep.
P.S. the audit problem (this topic) appears to be solved.
Calm down and touch base, guys - you are sharing the same goal here.
We all are.
I am well aware of the effort you put into testing, @jpgpi250, as well as of the amount of work and diligence you bring to this, DanSchaper and DL6ER, and the unfaltering support @jfb is bringing to this forums, and many others not mentioned here - and I guess so is anyone of us.
Seems we are just struggling for the best way to do it.
I'd be willing to lend a hand, by my coding days are well a decade behind me, and they did involve obscure languages no-one ever uses nowadays.
P.S.: Why can I only @
two users in a post???
where the bug was, in fact, in list no. 4. When weâd have automatically shown the list no. 5 address, the user would have removed/disabled the wrong list and the warning would have shown up again, this time maybe with list no. 6.
If this is the case then it wouldn't then be possible to flag "bad" lists because of the way you are pre-parsing them to a single file (if I'm understanding this correctly) Bad lists could taint the good one's via this method...
P.S.: Why can I only
@
to users in post???
We all read the posts, there's really no need to ping us and email/page/alert us and other users. And no need to @
more than 2 people in a post.
Update pushed to remove the double output.
output now looks like this:
[â] Storing downloaded domains in new gravity database
Encountered non-critical SQL warnings. Please check the suitability of the lists you're using!
SQL warnings:
- /tmp/tmp.iJvu6p46n0.gravity:1868666: expected 2 columns but found 3 - extras ignored
Line contains: denizbank-balbey.subesi.tc,,34
[â] Building tree
This provides enough information to solve the problem.
Thanks again.
I have added many of the firebog lists and they all work fine.
error:
Encountered non-critical SQL warnings. Please check the suitability of the lists you're using!
SQL warnings:
- /tmp/tmp.iJvu6p46n0.gravity:1868666: expected 2 columns but found 3 - extras ignored
Line contains: denizbank-balbey.subesi.tc,,34
sql:
sqlite3 /etc/pihole/gravity.db "SELECT address FROM adlist WHERE id =34;"
https://raw.githubusercontent.com/HorusTeknoloji/TR-PhishingList/master/url-lists.txt
firebog:
raw.githubusercontent.com/HorusTeknoloji/TR-PhishingList/master/url-lists.txt
denizbank-balbey.subesi.tc,
That's not one of the lists I loaded, but the trailing "," is a problem. I would reject that list entirely. Then, when the list is cleaned up, it will all be imported again.
I would reject that list entirely
Send a message to Wally3K, hoping he'll fix it. It is the only error I've got, otherwise, I wouldn't even have noticed the fact that pihole -g now reports these errors, the entire discussion would never have happened...
Wally3K
Why, it's not his list. Try GitHub - HorusTeknoloji/TR-PhishingList: TĂŒrkiye'ye Yönelik Zararlı BaÄlantı EriĆim Engelleme Listesi
It has some other errors in it as well. Probably should be reviewed for continued use.
-akbank.com
-xn--yapkred-mza21d-com.usrfiles.com
0.php
I sent the list maintainer feedback on that line item.
Add the other domains I've noted in the edit.
Why, itâs not his list.
The list doesn't have any contact information. I hope that Wally3K has contact information for the lists he recommends, using his php page
The list doesnât have any contact information.
From the referenced Github page, in the Readme section, contact information:
Contact
For your questions, comments and suggestions: destek@horus.com.tr
The list doesnât have any contact information.
It's a github URL, what more do you need?
Edit: PR in the change you want to see in the world.
HorusTeknoloji:master
â lightswitch05:master
`spotify.com` is the legitimate website for the Spotify music streaming service.
HorusTeknoloji:master
â dschaper:master
Need to remove the trailing comma. Pi-hole v5 will reject the list. Signed-ofâŠ
I'll admit, that I have no clue on how to make a PR. DL6ER once asked me to submit a change in the pihole documentation for unbound, I've searched for a beginners manual (step by step) on how to do this, but didn't find one. I don't want to add or change the work of other people, until I know exactly how to do it the correct way.
I was looking at the RAW blocklist, also have no clue on how to get from RAW to regular view (which usually has a readme).
Apologies for my ignorance, also sorry that I'm causing so much trouble (annoy you)...
Anything that has the URL raw.githubusercontent.com is accessible as github.com.
http://raw.githubusercontent.com/HorusTeknoloji/TR-PhishingList/master/url-lists.txt is the same as GitHub - HorusTeknoloji/TR-PhishingList: TĂŒrkiye'ye Yönelik Zararlı BaÄlantı EriĆim Engelleme Listesi
I don't mind helping out users but you have to, at some point, start helping yourself and stop relying on others to do it all for you.
Edit: And to belabor the point, you should know exactly where to find the domain lists you are using. Do not just blindly rely on others to do the thinking for you. Adding in data you have no clue about is not smart for DNS.
I donât want to add or change the work of other people, until I know exactly how to do it the correct way.
The only way to learn is to do it, do it wrong, have others teach you how to do it right and then do it right. You're not going to learn to do it right the first time. No one can do that.
I've never worked with Git before either, but this looks like a good place to start...? https://help.github.com/en/desktop/contributing-to-projects
Edit: actually a Google search looks to have many howto's and Youtube video's on the matter