This issue is occurring on a newly provisioned and updated Raspbian Stretch OS. PiHole is the only package/application/utility that we had installed on it.
Expected Behaviour:
Within the PiHole Admin Web Console click Disable then click the 5 minute option. PiHole is then immediately disabled. Click the Enable option and PiHole is then immediately re-enabled.
Actual Behaviour:
When clicking Disable within the PiHole Admin Web Console then clicking the 5 minute option there is a small circle on the screen for an extended period of time. PiHole eventually disables after an extended period of time and then the 5 minute count down starts. When clicking Enable to reenable PiHole there is no response from the PiHole Admin Web Console for an extended period of time. Continuing to click on the Enable button re-enables PiHole after a period of time.
Debug Token:
3yh6o2s95q
I can confirm similar behaviour on my Pi, though the lag does not appear to be very much. @Don_Naismith
PiHole is installed on a Raspberry Pi 3 B+ and I'm accessing the PiHole admin web console from a Win10 PC using the latest version of Google Chrome. The Raspberry Pi 3 B+ was previously running Raspbian Jesse with a recent 3.x version of PiHole and there was no lag when clicking Disable / Enable. I was in the process of rebuilding the Pi with Raspian Stretch and PiHole 4.x when I noticed the behaviour.
DL6ER
August 12, 2018, 1:45pm
8
Do you notice the same delay when logging into your Pi and running
pihole enable
or
pihole disable
?
I'm seeing a similar delay.
DL6ER
August 12, 2018, 2:18pm
13
Okay, how active is your network (rough number of clients and a typical number of queries within 24 hours) and have you configured FTL somehow (edited /etc/pihole/pihole-FTL.conf)?
Can you run pihole -t in a separate terminal and try to identify if there is anything specific happening during this delay time?
This is a fresh build with Raspbian Stretch OS updated and default install of PiHole 4.x. Only one client is currently using it. Minimal activity. /etc/pihole/pihole-FTL.conf is blank.
DL6ER
August 12, 2018, 3:34pm
16
Okay, sorry for asking this as well, but how does the same GIF look for tail -f /var/log/pihole-FTL.log on the right side?
pi@raspberrypi:~ $ tail -f /var/log/pihole-FTL.log
DL6ER
August 13, 2018, 1:09pm
18
Just to let you know that we take the problem seriously: I propose a complete rewrite of our blocking infrastructure. This would also remove any delays in the enable/disable commands.
pi-hole:development ← pi-hole:tweak/reload_on_enable_disable
opened 12:36PM - 13 Aug 18 UTC
**By submitting this pull request, I confirm the following:**
*please fill any… appropriate checkboxes, e.g: [X]*
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [x] I have commented my proposed changes within the code.
- [x] I have tested my proposed changes, and have included unit tests where possible.
- [x] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
Please make sure you [Sign Off](https://github.com/pi-hole/pi-hole/wiki/How-to-signoff-your-commits.) all commits. Pi-hole enforces the [DCO](https://github.com/pi-hole/pi-hole/wiki/Contributing-to-the-project).
---
**What does this PR aim to accomplish and how does it accomplish it?:**
Change the method we use to disable/enable blocking. So far, we commented the config lines
```
addn-hosts=/etc/pihole/gravity.list
addn-hosts=/etc/pihole/black.list
```
and then restarting `pihole-FTL`. This is very inefficient and slow, as, on shutdown of `pihole-FTL`, we update the database and then on restart, import all queries again from the database.
This PR changes this. Instead of changing the configuration to not load the files, we replace them by empty files which are then reread on `reload`ing `pihole-FTL`. The old files are kept as backup and restored on `pihole enable`. This is a much cleaner variant of handling the blocking status and also *much* faster than always restarting the daemon. It solves a number of delay issues recently reported with the Enable/Disable functionality of Pi-hole.
Pi-hole `gravity` is modified to update the backup files when blocking is disabled.
The current blocking status is tracked by setting the new variable `BLOCKED_ENABLED` in `setupVars.conf`.
5 Likes
system
September 3, 2018, 1:09pm
19
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.
