In /admin/settings/api
It does not end the session running on iPhone using Safari. You click 'delete session' and it does not do anything.
Also cannot end a session running on Chrome.
DL6ER
October 19, 2023, 5:07pm
2
Thank you for the report. I checked this and can confirm that deleting via the multi-select and then clicking on the gray trash icon doesn't work due to two minor (but still significant enough) typos in the code fixed by
pi-hole:development-v6 ← pi-hole:fix/session_delete
opened 05:07PM - 19 Oct 23 UTC
# What does this implement/fix?
See title and related Discourse topic.
**R… elated issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
However, the red trash buttons at the end of every line still work for me, did you test those as well?
Yes they worked on some, but for example a session running on safari on iPhone does not end.
Just tested on an iPad Pro running Safari and the red trash can worked fine - shouldn't have thought there would be a difference between Phone and Pad in this case?
Apologies, I might have not been clear. I am trying to delete a session that is running on Safari via Edge on Windows.
See below video recording which hopefully will help show what I am referring too.
That's... interesting. Though I still cannot repro:
Do you have any extensions on Edge that could be interfering with the javascript? Do you see any errors on the console (F12) when clicking the button?
Just went to check and now it's working.. odd..
