Deleting a Group is not possible - FTL v6.0.4

DirtyPants · February 28, 2025, 9:04am

Hi Pi-hole Team

I updated my Installation to Pi-hole v6, but it failed so I had to do a reinstall. After the reinstall I imported my backup through the Pi-hole Webinterface. Everything works like before, except deleting a group. Yesterday I wanted to delete a group and get the following message in return.

Could not remove entries from table
FOREIGN KEY constraint failed

I think the reinstall with a backup messed something up.

Could you maybe help me out what causes this problem?

Thanks a lot in advance

Debug Token:
https://tricorder.pi-hole.net/BR8ER6XX/

ASD · March 2, 2025, 12:16pm

Hi,
I have the same .. some detail i find:
I can delete groups created with v6 but cant delete groups which was created with v5 before the update.

DirtyPants · March 9, 2025, 4:18pm

Push

DirtyPants · March 23, 2025, 9:16pm

Push…
Still have this problem, maybe someone can help.

jfb · March 23, 2025, 9:21pm

Please upload a new debug log and post the new token URL. Your previous log expired before we got to it.

DirtyPants · March 24, 2025, 8:36pm

Sure. New token is: https://tricorder.pi-hole.net/1akff5S2/

rdwebdesign · March 25, 2025, 3:26am

This message means the database can't delete the group because there are lists and domains using it.

This is different from the Pi-hole v5 behavior, where you can remove a group even if it is used.

I think this can be considered an issue and I can replicate it.

DL6ER · March 27, 2025, 12:12pm

Bugfix:

github.com/pi-hole/pi-hole

Add ON DELETE CASCADE to FOREIGN KEY REFERENCES in gravity.db

development ← tweak/on_delete_cascade

opened 12:12PM - 27 Mar 25 UTC

DL6ER

+6 -6

# What does this implement/fix? There has been a report on Discourse (link be…low) that deleting groups which still have, e.g., domains assigned to them is not possible without *first* unassigning said domains from the respective groups. This behavior was different in v5 where deleting a group cascaded down in deleting all the domains, clients, etc. assigned to it. I don't think that such a massive "cleanup" is actually a good idea as a wrong click can erase quite a bit of work users may have invested into their systems. Hence, this PR seeks a middle ground: When a group is being deleted, we cascade this into the `domain<->group`, `client<->group`, and `adlist<->group` bindings, effectively disassigning the domains *without deleting them*. To me, this makes more sense. This makes it possible to delete groups even when domains are assigned, making the latter orphans without any effect. They can later either be deleted on their own or adopted into new groups. --- **Related issue or feature (if applicable):** https://discourse.pi-hole.net/t/deleting-a-group-is-not-possible-ftl-v6-0-4/77171 **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.

rdwebdesign · March 27, 2025, 9:51pm

I agree with the new code (just removing the assignment, without actually deleting the "child" items) is the best approach.

DL6ER · March 28, 2025, 5:09pm

We are currently working on the fix but it is unclear what should actually happen. What is your opinion how this feature should work?

It should not be possible to delete groups which still have associated domains or clients
It should be possible to delete groups which still have associated domains or clients. The previously associated domains and clients should remain, but unassigned from the just deleted group
It should be possible to delete groups which still have associated domains or clients. Associated domains and clients should be removed as well (cascading deletion down)

0 voters

system · April 18, 2025, 5:10pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.