Matt
July 16, 2020, 2:55am
1
Title is fairly descriptive - now that themes are an option, it would be nice to match default Pi-hole theme to user's system theme leveraging the prefers-color-scheme CSS feature: prefers-color-scheme - CSS: Cascading Style Sheets | MDN
Cheers, and thanks for the great update!
Implemented a long time ago:
pi-hole:devel
← AlexLamond:auto-darkmode
opened 05:46PM - 21 Jun 21 UTC
Signed-off-by: = <9060360+AlexLamond@users.noreply.github.com>
**By submittin… g this pull request, I confirm the following:** `{please fill any appropriate checkboxes, e.g: [X]}`
`{Please ensure that your pull request is for the 'devel' branch!}`
- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
- [X] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff))
---
**What does this PR aim to accomplish?:**
`{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}`
This PR adds the ability to set the PiHole theme to auto, enabling users to have light mode when the device is in light mode and dark mode when the device is in dark mode
**How does this PR accomplish the above?:**
`{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}`
The PR adds an additional CSS document that applies the relevant theme on the device theme and adds the option to the themes.php file
**What documentation changes (if any) are needed to support this PR?:**
None
https://user-images.githubusercontent.com/9060360/122807394-d47ba880-d2cb-11eb-9c2d-81c966e3c1d9.mp4
pi-hole:devel
← pi-hole:default_theme
opened 07:43PM - 15 Dec 21 UTC
- [x] I have read and understood the [contributors guide](https://github.com/pi-… hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [ ] I have commented my proposed changes within the code.
- [ ] I have tested my proposed changes.
- [x] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
- [x] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff))
---
**What does this PR aim to accomplish?:**
Sets the default theme to auto mode (dark/light).
Fixes https://github.com/pi-hole/pi-hole/issues/4467
For discussion.