Debug progress bar

yubiuser · May 31, 2022, 9:30pm

development ← rdwebdesign:debuglog_improvements

opened 10:36PM - 14 Mar 22 UTC

**By submitting this pull request, I confirm the following:** - [x] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [x] I have made only one major change in my proposed changes. - [x] I have commented my proposed changes within the code. - [x] I have tested my proposed changes, and have included unit tests where possible. - [x] I am willing to help maintain this change if there are issues with it later. - [x] I give this submission freely and claim no ownership. - [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** This PR allows `lighttpd` to stream large contents to the browser. A few years a go, `lighttpd` default settings were defined to buffer as little as possible and stream the content. Now, the current default setting is to always buffer the entire response before send it to the browser. As a result, the browser only receives the "Debug log" after it is completely finished. Using a new configuration the browser will start to receive the log as soon as possible. **How does this PR accomplish the above?:** Adding the corresponding `lighttpd` configuration. <details><summary>Lighttpd Reference</summary> <a href="https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_stream-response-bodyDetails">https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_stream-response-bodyDetails</a> </details> <details><summary>Technical details</summary> We replaced: <ul> <li><del><code>stream-response-body = 0</code> (default) buffer entire response body before sending to client</del> with</li> <li><code>stream-response-body = 1</code> stream response body to client</li> </ul> lighttpd Docs recommends to set <code>ssl.read-ahead=disable</code>, when operating in a memory constrained environment and using HTTPS. However, this configuration required <code>mod_openssl</code> which we do not use, because we don't use HTTPS for the web interface. <code>ssl.read-ahead=disable</code> is also the default value, so adding it would not have any effect. </details> **What documentation changes (if any) are needed to support this PR?:** none

Released with Pi-hole FTL v5.15, Web v5.12 and Core v5.10 released