2 Things, first, the text is white on a white background on the bar graph as seen below. I cleared the logs to make it more apparent.
And second, the percentage of blocked is in relation to permitted queries as opposed to the total queries.
DL6ER
February 4, 2020, 9:42pm
2
Which browser do you use? It may not fully support all the features. Can you check with a more widely spread browser like, maybe, Firefox or Chrome?
Thanks, this will be fixed by
pi-hole:release/v5.0
← pi-hole:fix/percentages
opened 09:41PM - 04 Feb 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fix computation of percentages in the over-time graph
**How does this PR accomplish the above?:**
Fix ratio to be computed against number of total, not permitted queries.
**What documentation changes (if any) are needed to support this PR?:**
None
Brave Browser is the one exhibiting the issue. Both chrome and safari are correct. Sorry, I meant to edit this post for that discovery. Otherwise, things are working quite well for my particular setup...thanks
DL6ER
February 4, 2020, 10:00pm
4
This seems to be an issue inside Brave browser and is independent of Pi-hole, see, e.g., here
opened 08:45PM - 19 Oct 18 UTC
closed 09:19PM - 19 Oct 18 UTC
closed/invalid
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
Creating a dynamic canvas element and attempting to use its 2d context to measure text always renders a width of '0'.
## Steps to Reproduce
https://jsfiddle.net/jdmtu2xL/
## Actual result:
Width of test string "Testing...1..2...3...." is: 0 :(
## Expected result:
Width of test string "Testing...1..2...3...." is: 114.392578125 :)
## Reproduces how often:
Consistently
## Brave version (brave://version info)
Brave: 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision: 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS: Mac OS X
### Website problems only:
- Does the issue resolve itself when disabling Brave Shields? no
- Is the issue reproducible on the latest version of Chrome? no
Thanks for Brave!
Ronnick
February 4, 2020, 10:02pm
5
I assumed it was specific to Brave. Just forgot to clarify that chrome and safari were unaffected.
DL6ER
February 7, 2020, 2:25pm
6
The mentioned bugfix has been merged into the beta branch.