In the latest update blacklist and whitelist have been combined in domains,
In an overview it's hard to see directly which is which.
Is it possible to color code the type?
like whitelist is green of white, and blacklist red or block or something?
1 Like
Sounds like a good idea and shouldn't be that hard to implement.
I don't say colours are not something to discuss, meanwhile we implemented something else:
pi-hole:devel
← pi-hole:filter_domains
opened 11:03PM - 05 Sep 22 UTC
### What does this PR aim to accomplish?:
After a recent update, all domains … are shown on the same page.
This PR adds the ability to filter domains by type, allowing turn on/off the visibility of:
- Exact whitelists;
- Exact blacklists;
- Regex whitelists;
- Regex blacklists.
### How does this PR accomplish the above?:
Adding a filter and checkboxes to control the filter.
![image](https://user-images.githubusercontent.com/1385443/188782343-66bb007a-1102-46e8-89f1-5175e0485530.png)
### What documentation changes (if any) are needed to support this PR?:
none.
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
- [x] I have read the above and my PR is ready for review. _Check this box to confirm_
1 Like
Using the filter will make it easier to isolate whitelists, blacklists and regex than using colors.
1 Like
Thnx. I think a filter would be a great addition as well.
system
Closed
September 17, 2022, 6:39am
6
This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.